Allow a "-j" or "--jobs" argument to "docker-php-ext-install" to speed up extension building #159
Conversation
…d up extension building
|
Thanks for the prod, @soullivaneuh 👍 |
|
For testing this, I did |
|
LGTM |
Allow a "-j" or "--jobs" argument to "docker-php-ext-install" to speed up extension building
|
Thank you! But I don't think this is useful for When this patch will be available from DockerHub? I'm pretty new with this system, I don't know how it works. :-) |
|
Yeah, the addition to "install" and "clean" was just for consistency; it
probably won't help, but it's harmless unless the Makefile is dangerously
poorly-coded (which I'd be very surprised to find PHP's to be). 😄
As noted in https://github.com/docker-library/php/blob/master/README.md,
this won't hit the Hub until a PR is made over in
https://github.com/docker-library/official-images with an update.
|
So you're telling that I should submit the same ph on docker-library/official-images? And then, this will be automatically available? Thanks. |
- `mariadb` bump to `5.5.46` - `php` add `--jobs` to dokcer-php-ext-install docker-library/php#159 - `tomcat` bump `7.0.67`
- `mariadb` bump to `5.5.46` - `php` add `--jobs` to docker-php-ext-install docker-library/php#159 - `tomcat` bump `7.0.67`
- `mariadb` bump to `5.5.46` - `php` add `--jobs` to docker-php-ext-install, see docker-library/php#159 - `tomcat` bump `7.0.67`
|
Thanks for being willing but you don't have to make the PR. I got this docker-library/official-images#1264. 😄 |
|
Great, thanks! 👍 |
- `mariadb` bump to `5.5.46` - `php` add `--jobs` to docker-php-ext-install, see docker-library/php#159 - `tomcat` bump `7.0.67`
- `mariadb` bump to `5.5.46` - `php` add `--jobs` to docker-php-ext-install, see docker-library/php#159 - `tomcat` bump `7.0.67`
| opts="$(getopt -o 'h?j:' --long 'help,jobs:' -- "$@" || { usage >&2 && false; })" | ||
| eval set -- "$opts" | ||
|
|
||
| j=1 |
There was a problem hiding this comment.
I wonder if this should default to $(nproc).
There was a problem hiding this comment.
docker-library/drupal#154 (comment):
It defaults to
make's default (we don't explicitly-j1anywhere), mostly to be considerate ofphpusers' machines -- for the official images though, we want to make full use of our build systems as much as possible (especially chasing the dragon of potentially faster builds), which is why we typically use-j "$(nproc)"in ours.
Fixes #144