Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node: Add node.js v12.0.0 with Yarn v1.15.2 #5789

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Node: Add node.js v12.0.0 with Yarn v1.15.2 #5789

merged 1 commit into from
Apr 24, 2019

Conversation

nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot mentioned this pull request Apr 24, 2019
Merged
@lovell lovell mentioned this pull request Apr 24, 2019
Closed
@yosifkit
Copy link
Member

Diff: 
diff --git a/_bashbrew-arches b/_bashbrew-arches
index da2feb6..9fea0d8 100644
--- a/_bashbrew-arches
+++ b/_bashbrew-arches
@@ -1,3 +1,19 @@
+node:12.0 @ amd64
+node:12.0 @ arm32v7
+node:12.0 @ arm64v8
+node:12.0 @ ppc64le
+node:12.0 @ s390x
+node:12.0-alpine @ amd64
+node:12.0-alpine @ arm32v6
+node:12.0-alpine @ arm64v8
+node:12.0-alpine @ i386
+node:12.0-alpine @ ppc64le
+node:12.0-alpine @ s390x
+node:12.0-slim @ amd64
+node:12.0-slim @ arm32v7
+node:12.0-slim @ arm64v8
+node:12.0-slim @ ppc64le
+node:12.0-slim @ s390x
 node:alpine @ amd64
 node:alpine @ arm32v6
 node:alpine @ arm64v8
diff --git a/_bashbrew-list b/_bashbrew-list
index 42cb8a4..d5862c0 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -82,6 +82,16 @@ node:11.14.0-alpine
 node:11.14.0-slim
 node:11.14.0-stretch
 node:11.14.0-stretch-slim
+node:12.0
+node:12.0-alpine
+node:12.0-slim
+node:12.0-stretch
+node:12.0-stretch-slim
+node:12.0.0
+node:12.0.0-alpine
+node:12.0.0-slim
+node:12.0.0-stretch
+node:12.0.0-stretch-slim
 node:alpine
 node:boron
 node:boron-alpine
diff --git a/node_boron-alpine/Dockerfile b/node_12.0-alpine/Dockerfile
similarity index 99%
copy from node_boron-alpine/Dockerfile
copy to node_12.0-alpine/Dockerfile
index 0072f4f..923ebff 100644
--- a/node_boron-alpine/Dockerfile
+++ b/node_12.0-alpine/Dockerfile
@@ -1,6 +1,6 @@
 FROM alpine:3.9
 
-ENV NODE_VERSION 6.17.1
+ENV NODE_VERSION 12.0.0
 
 RUN addgroup -g 1000 node \
     && adduser -u 1000 -G node -s /bin/sh -D node \
diff --git a/node_boron-slim/Dockerfile b/node_12.0-slim/Dockerfile
similarity index 99%
copy from node_boron-slim/Dockerfile
copy to node_12.0-slim/Dockerfile
index d78d1a5..f7882dd 100644
--- a/node_boron-slim/Dockerfile
+++ b/node_12.0-slim/Dockerfile
@@ -3,7 +3,7 @@ FROM debian:stretch-slim
 RUN groupadd --gid 1000 node \
   && useradd --uid 1000 --gid node --shell /bin/bash --create-home node
 
-ENV NODE_VERSION 6.17.1
+ENV NODE_VERSION 12.0.0
 
 RUN buildDeps='xz-utils' \
     && ARCH= && dpkgArch="$(dpkg --print-architecture)" \
diff --git a/node_boron/Dockerfile b/node_12.0/Dockerfile
similarity index 99%
copy from node_boron/Dockerfile
copy to node_12.0/Dockerfile
index 8314818..c663360 100644
--- a/node_boron/Dockerfile
+++ b/node_12.0/Dockerfile
@@ -3,7 +3,7 @@ FROM buildpack-deps:stretch
 RUN groupadd --gid 1000 node \
   && useradd --uid 1000 --gid node --shell /bin/bash --create-home node
 
-ENV NODE_VERSION 6.17.1
+ENV NODE_VERSION 12.0.0
 
 RUN ARCH= && dpkgArch="$(dpkg --print-architecture)" \
   && case "${dpkgArch##*-}" in \

@yosifkit
Copy link
Member

Build test of #5789; f26448f; amd64 (node):

$ bashbrew build node:8.16.0-jessie
Using bashbrew/cache:f42167492e115fc629ee52087115f5c00d532b4ed96a7667e0e679bd34a2f341 (node:8.16.0-jessie)
Tagging node:8.16.0-jessie
Tagging node:8.16-jessie
Tagging node:8-jessie
Tagging node:carbon-jessie

$ test/run.sh node:8.16.0-jessie
testing node:8.16.0-jessie
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.16.0-jessie-slim
Using bashbrew/cache:ea9fafadaf57da38e3a8e0bce96ae1cff5e212de220dca976d1300a8981f824c (node:8.16.0-jessie-slim)
Tagging node:8.16.0-jessie-slim
Tagging node:8.16-jessie-slim
Tagging node:8-jessie-slim
Tagging node:carbon-jessie-slim

$ test/run.sh node:8.16.0-jessie-slim
testing node:8.16.0-jessie-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.16.0-alpine
Using bashbrew/cache:add22955d7e9f64fd0cf1d74e0a760a8de5571e9c4e4f68f188f9d713ee84550 (node:8.16.0-alpine)
Tagging node:8.16.0-alpine
Tagging node:8.16-alpine
Tagging node:8-alpine
Tagging node:carbon-alpine

$ test/run.sh node:8.16.0-alpine
testing node:8.16.0-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.16.0-stretch
Using bashbrew/cache:8e6e2983e2b4c53cc9da7ac927499482d5d83ca0d38e32d8246a6d338448c466 (node:8.16.0-stretch)
Tagging node:8.16.0-stretch
Tagging node:8.16-stretch
Tagging node:8-stretch
Tagging node:carbon-stretch
Tagging node:8.16.0
Tagging node:8.16
Tagging node:8
Tagging node:carbon

$ test/run.sh node:8.16.0-stretch
testing node:8.16.0-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.16.0-stretch-slim
Using bashbrew/cache:7d9631bd591b255837b99cd8dfee15b8af974e059a157de7b772396e540f7a31 (node:8.16.0-stretch-slim)
Tagging node:8.16.0-stretch-slim
Tagging node:8.16-stretch-slim
Tagging node:8-stretch-slim
Tagging node:carbon-stretch-slim
Tagging node:8.16.0-slim
Tagging node:8.16-slim
Tagging node:8-slim
Tagging node:carbon-slim

$ test/run.sh node:8.16.0-stretch-slim
testing node:8.16.0-stretch-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.17.1-jessie
Using bashbrew/cache:8e5b3ad3525daa6d3f7bc90edc1b84148fe4b5f8bf5c0cf65ff6ddec7752c5cd (node:6.17.1-jessie)
Tagging node:6.17.1-jessie
Tagging node:6.17-jessie
Tagging node:6-jessie
Tagging node:boron-jessie

$ test/run.sh node:6.17.1-jessie
testing node:6.17.1-jessie
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.17.1-jessie-slim
Using bashbrew/cache:4dc7e5570b8546e3b1ca42e218f752e7411c587fe5e12213d9e09e0e85ca3a3e (node:6.17.1-jessie-slim)
Tagging node:6.17.1-jessie-slim
Tagging node:6.17-jessie-slim
Tagging node:6-jessie-slim
Tagging node:boron-jessie-slim

$ test/run.sh node:6.17.1-jessie-slim
testing node:6.17.1-jessie-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.17.1-alpine
Using bashbrew/cache:dc272c709cd32bf70f495a6ef9a30345fcc0f040b2bf277062d435b219cce183 (node:6.17.1-alpine)
Tagging node:6.17.1-alpine
Tagging node:6.17-alpine
Tagging node:6-alpine
Tagging node:boron-alpine

$ test/run.sh node:6.17.1-alpine
testing node:6.17.1-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.17.1-stretch
Using bashbrew/cache:35f969f8d2b8c191a8044884984d3bbf8d435d967b39f8bbcecd79018a77c05d (node:6.17.1-stretch)
Tagging node:6.17.1-stretch
Tagging node:6.17-stretch
Tagging node:6-stretch
Tagging node:boron-stretch
Tagging node:6.17.1
Tagging node:6.17
Tagging node:6
Tagging node:boron

$ test/run.sh node:6.17.1-stretch
testing node:6.17.1-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:6.17.1-stretch-slim
Using bashbrew/cache:824ce51143311a46c06548f38e7ce75a26e2857f71ad9cd59de12ae40dc3d4f7 (node:6.17.1-stretch-slim)
Tagging node:6.17.1-stretch-slim
Tagging node:6.17-stretch-slim
Tagging node:6-stretch-slim
Tagging node:boron-stretch-slim
Tagging node:6.17.1-slim
Tagging node:6.17-slim
Tagging node:6-slim
Tagging node:boron-slim

$ test/run.sh node:6.17.1-stretch-slim
testing node:6.17.1-stretch-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:12.0.0-alpine
Building bashbrew/cache:39ce6b96cb9d92044908b47b276023ddee83741a0270da993b8667951ddeb25a (node:12.0.0-alpine)
Tagging node:12.0.0-alpine
Tagging node:12.0-alpine

$ test/run.sh node:12.0.0-alpine
testing node:12.0.0-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:12.0.0-stretch
Building bashbrew/cache:a9f32e68dabf61d7aa2771e7d9193d73d4c2d3a7bceb0cf6bc2bb423fb9d4e65 (node:12.0.0-stretch)
Tagging node:12.0.0-stretch
Tagging node:12.0-stretch
Tagging node:12.0.0
Tagging node:12.0

$ test/run.sh node:12.0.0-stretch
testing node:12.0.0-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:12.0.0-stretch-slim
Building bashbrew/cache:8ceb7f75c56685b55d037ce53fa6d14b89f736eadd95abca2ee443d6b44f9ef3 (node:12.0.0-stretch-slim)
Tagging node:12.0.0-stretch-slim
Tagging node:12.0-stretch-slim
Tagging node:12.0.0-slim
Tagging node:12.0-slim

$ test/run.sh node:12.0.0-stretch-slim
testing node:12.0.0-stretch-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:11.14.0-alpine
Using bashbrew/cache:b04fdc81971a2260ceabbff3919c3bc79a6964ef2d9a725d258523897b086903 (node:11.14.0-alpine)
Tagging node:11.14.0-alpine
Tagging node:11.14-alpine
Tagging node:11-alpine
Tagging node:current-alpine
Tagging node:alpine

$ test/run.sh node:11.14.0-alpine
testing node:11.14.0-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:11.14.0-stretch
Using bashbrew/cache:747a9e14055ff6b3a1671b256b7ad9e46ba6014f786bce626135aeb1a2a3cb3b (node:11.14.0-stretch)
Tagging node:11.14.0-stretch
Tagging node:11.14-stretch
Tagging node:11-stretch
Tagging node:current-stretch
Tagging node:stretch
Tagging node:11.14.0
Tagging node:11.14
Tagging node:11
Tagging node:current
Tagging node:latest

$ test/run.sh node:11.14.0-stretch
testing node:11.14.0-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:11.14.0-stretch-slim
Using bashbrew/cache:9485ce4ab1e00fdf2802503c35cea74a9fcf0d377bf50b6ef7b966fd1e829185 (node:11.14.0-stretch-slim)
Tagging node:11.14.0-stretch-slim
Tagging node:11.14-stretch-slim
Tagging node:11-stretch-slim
Tagging node:current-stretch-slim
Tagging node:stretch-slim
Tagging node:11.14.0-slim
Tagging node:11.14-slim
Tagging node:11-slim
Tagging node:current-slim
Tagging node:slim

$ test/run.sh node:11.14.0-stretch-slim
testing node:11.14.0-stretch-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:10.15.3-jessie
Using bashbrew/cache:a0e99b1ca0385dd30306e95f0068ff4058f27cb25eb698081fedab41536d8ef6 (node:10.15.3-jessie)
Tagging node:10.15.3-jessie
Tagging node:10.15-jessie
Tagging node:10-jessie
Tagging node:dubnium-jessie
Tagging node:lts-jessie

$ test/run.sh node:10.15.3-jessie
testing node:10.15.3-jessie
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:10.15.3-jessie-slim
Using bashbrew/cache:25e4818e94aa036a615487e5f6a944d7f55ffd82a29d18d22185acad2293f362 (node:10.15.3-jessie-slim)
Tagging node:10.15.3-jessie-slim
Tagging node:10.15-jessie-slim
Tagging node:10-jessie-slim
Tagging node:dubnium-jessie-slim
Tagging node:lts-jessie-slim

$ test/run.sh node:10.15.3-jessie-slim
testing node:10.15.3-jessie-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:10.15.3-alpine
Using bashbrew/cache:09bdcabf562cd56ce7f4018932cd3677c3c6370b41418cf962d0b089b34c9883 (node:10.15.3-alpine)
Tagging node:10.15.3-alpine
Tagging node:10.15-alpine
Tagging node:10-alpine
Tagging node:dubnium-alpine
Tagging node:lts-alpine

$ test/run.sh node:10.15.3-alpine
testing node:10.15.3-alpine
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:10.15.3-stretch
Using bashbrew/cache:25c31910286b522bb49cc8a7da4e78a0f9ced3e4d487331cc190b7d59a8a81ab (node:10.15.3-stretch)
Tagging node:10.15.3-stretch
Tagging node:10.15-stretch
Tagging node:10-stretch
Tagging node:dubnium-stretch
Tagging node:lts-stretch
Tagging node:10.15.3
Tagging node:10.15
Tagging node:10
Tagging node:dubnium
Tagging node:lts

$ test/run.sh node:10.15.3-stretch
testing node:10.15.3-stretch
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:10.15.3-stretch-slim
Using bashbrew/cache:8e545d13fa83eafb22bec9f012f4711542be1fa45dd4f0a2cf7429f89c3e987a (node:10.15.3-stretch-slim)
Tagging node:10.15.3-stretch-slim
Tagging node:10.15-stretch-slim
Tagging node:10-stretch-slim
Tagging node:dubnium-stretch-slim
Tagging node:lts-stretch-slim
Tagging node:10.15.3-slim
Tagging node:10.15-slim
Tagging node:10-slim
Tagging node:dubnium-slim
Tagging node:lts-slim

$ test/run.sh node:10.15.3-stretch-slim
testing node:10.15.3-stretch-slim
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:chakracore-8.11.1
Building bashbrew/cache:d06fd4e2ce45f6bbfa09faf6f522c89939d831bb3504a19897fb13c9baea788f (node:chakracore-8.11.1)
Tagging node:chakracore-8.11.1
Tagging node:chakracore-8.11
Tagging node:chakracore-8

$ test/run.sh node:chakracore-8.11.1
testing node:chakracore-8.11.1
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:chakracore-10.13.0
Building bashbrew/cache:416330766fa3dca77649b4d460ae072d2bde6368451826c594dd7201d9552cf4 (node:chakracore-10.13.0)
Tagging node:chakracore-10.13.0
Tagging node:chakracore-10.13
Tagging node:chakracore-10
Tagging node:chakracore

$ test/run.sh node:chakracore-10.13.0
testing node:chakracore-10.13.0
	'utc' [1/5]...passed
	'cve-2014--shellshock' [2/5]...passed
	'no-hard-coded-passwords' [3/5]...passed
	'override-cmd' [4/5]...passed
	'node-hello-world' [5/5]...passed


$ bashbrew build node:8.16.0-onbuild
Using bashbrew/cache:a21fdad18cd4c272bf812450b7104d8449ca98df6a41dfe125b4abd4e0a2cf25 (node:8.16.0-onbuild)
Tagging node:8.16.0-onbuild
Tagging node:8.16-onbuild
Tagging node:8-onbuild
Tagging node:carbon-onbuild

$ test/run.sh node:8.16.0-onbuild
testing node:8.16.0-onbuild
	'override-cmd' [1/1]...passed


$ bashbrew build node:6.17.1-onbuild
Using bashbrew/cache:75b64b13641679b67c7167b7220b487337101ca8af29b58f7b6975cc64ca6e5c (node:6.17.1-onbuild)
Tagging node:6.17.1-onbuild
Tagging node:6.17-onbuild
Tagging node:6-onbuild
Tagging node:boron-onbuild

$ test/run.sh node:6.17.1-onbuild
testing node:6.17.1-onbuild
	'override-cmd' [1/1]...passed

@yosifkit yosifkit merged commit d155303 into docker-library:master Apr 24, 2019
@SimenB SimenB mentioned this pull request Apr 25, 2019
Merged
@nschonni nschonni deleted the travis-109381800 branch January 5, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
library/node
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nodejs-github-bot @yosifkit @docker-library-bot