Traefik: Introduce the first windows image #4650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…16) + Adding myself as maintainer Signed-off-by: Damien DUPORTAL <damien.duportal@gmail.com>
|
Following practise in #4602 : /cc @vdemeester @emilevauge @ldez Cheers ! |
emilevauge
suggested changes
Jul 30, 2018
There was a problem hiding this comment.
@dduportal we have few concerns, we should discuss a bit more on this one before merging :)
|
@emilevauge ack. I'm closing this issue time to fix the internals concerns and we'll go again as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the issue traefik/traefik#3603 on the Træfik's issue tracker,
I am happy to introduce a first declination of a Windows Container image for Træfik.
This image is based on the
nanoserver-sac2016variant: this is not the most recent, but it is a first start. Although we are planning to improve to other declination, some work have to be done on Golang and Træfik's sides as explained in traefik/traefik#3603 (comment) by @StefanScherer.The related work can be found here: containous/traefik-library-image#31 .
Let me know if anything else is needed !
PS: a big THANK YOU to @StefanScherer and @tianon for their help, guidance and explanations!
Signed-off-by: Damien DUPORTAL damien.duportal@gmail.com