Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set GOARM=7 explicitly for arm32v7 images #498

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Set GOARM=7 explicitly for arm32v7 images #498

merged 1 commit into from
Dec 9, 2023

Commits on Dec 9, 2023

  1. Set GOARM=7 explicitly for arm32v7 images 

    This fixes the disparity between the "armv6" download of Go from upstream and the image being v7 otherwise (and thus the default value of `GOARM` being `6` instead of `7`, which is unexpected for users of the image).

This is set in such a way that environment variables (or `go env -w`) will override it, but without requiring us to recompile Go (which I'm not convinced gives us much gain -- happy to reconsider if someone comes up with a good way to benchmark the compiler).
    @tianon
    tianon committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    40db26d View commit details
    Browse the repository at this point in the history