Add Alpine 3.19 variant #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Dec 8, 2023
| "3.18", | ||
| "3.17" | ||
| "3.19", | ||
| "3.18" |
There was a problem hiding this comment.
Might be worth adding our empty hack here to make the diff cleaner next time (not worth cycling this time IMO ❤️).
Suggested change
| "3.18" | |
| "3.18", | |
| empty |
|
Merging without Windows builds finishing because Alpine is good 😂 |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 8, 2023
Changes: - docker-library/golang@9f8bfe7: Merge pull request docker-library/golang#497 from jnoordsij/add-alpine-3.19 - docker-library/golang@84f47a9: Update templates to add Alpine 3.19 and drop 3.17 - docker-library/golang@5f181d7: Add Alpine 3.19 and drop 3.17 to versions.sh
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 9, 2023
Changes: - docker-library/golang@acf6e86: Merge pull request docker-library/golang#498 from infosiftr/GOARM=7 - docker-library/golang@40db26d: Set GOARM=7 explicitly for arm32v7 images - docker-library/golang@9f8bfe7: Merge pull request docker-library/golang#497 from jnoordsij/add-alpine-3.19 - docker-library/golang@84f47a9: Update templates to add Alpine 3.19 and drop 3.17 - docker-library/golang@5f181d7: Add Alpine 3.19 and drop 3.17 to versions.sh
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modelled after #460.
This PR adds a variant for Alpine 3.19 and drops the 3.17 variant at the same time.
See also https://alpinelinux.org/posts/Alpine-3.19.0-released.html.
Note: the Alpine 3.19 base Docker image is yet to appear here, so automated checks will fail up till then; see also docker-library/official-images#15852.Edit: the Alpine 3.19 base images are now available, so this is now ready for a retrigger of the workflow!