Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[19.03] Jenkinsfile: ensure all containers are cleaned up #371

Merged
merged 1 commit into from
Sep 20, 2019
Merged

[19.03] Jenkinsfile: ensure all containers are cleaned up #371

merged 1 commit into from
Sep 20, 2019

Conversation

andrewhsu
Copy link

@andrewhsu andrewhsu commented Sep 19, 2019 •
edited by thaJeztah
Loading

Clean cherry-pick of f470698 (moby#39957):

$ git cherry-pick -s -x f470698c2c10c2382080fab34f83088450fabdd6
[clean 4b5c535be9] Jenkinsfile: ensure all containers are cleaned up
 Author: Tibor Vass <tibor@docker.com>
 Date: Wed Sep 18 21:47:58 2019 +0000
 1 file changed, 2 insertions(+)

@andrewhsu
Jenkinsfile: ensure all containers are cleaned up
4b5c535 
By convention, containers spawned by jenkins jobs have the name:
docker-pr${BUILD_NUMBER}

That works fine for jobs with a single container. This commit cleans up
when multiple containers are spawned with the convention that their names
share the same "docker-pr${BUILD_NUMBER}-" prefix.

Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit f470698)
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
@andrewhsu andrewhsu added this to the 19.03.3 milestone Sep 19, 2019
@andrewhsu andrewhsu requested a review from tiborvass September 19, 2019 23:44
@andrewhsu andrewhsu merged commit 23c7134 into docker-archive:19.03 Sep 20, 2019
@andrewhsu andrewhsu deleted the clean branch September 20, 2019 00:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tiborvass tiborvass tiborvass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
19.03.3
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewhsu @tiborvass