Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[19.03] bump swarmkit to 4fb9e961aba635f0240a140e89ece6d6c2082585 (bump_v19.03) #306

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

thaJeztah
Copy link
Member

full diff: moby/swarmkit@961ec3a...4fb9e96

included:

@thaJeztah thaJeztah added this to the 19.03.1 milestone Jul 30, 2019
@thaJeztah
Copy link
Member Author

@dperny @dani-docker @kolyshkin PTAL

@thaJeztah thaJeztah modified the milestones: 19.03.1, 19.03.2 Jul 30, 2019
@thaJeztah
Copy link
Member Author

WindowsRS1 is a flaky test; https://jenkins.dockerproject.org/job/Docker-PRs-WoW-RS1/26097/console

01:43:53 FAIL: docker_cli_start_test.go:190: DockerSuite.TestStartReturnCorrectExitCode
01:43:53 
01:43:53 docker_cli_start_test.go:200:
01:43:53     c.Assert(exitCode, checker.Equals, 12, check.Commentf("out: %s", out))
01:43:53 ... obtained int = 125
01:43:53 ... expected int = 12
01:43:53 ... out: time="2019-07-30T01:43:53Z" level=error msg="error waiting for container: EOF" 
01:43:53 

Janky; https://jenkins.dockerproject.org/job/Docker-PRs/55091/console

01:52:59 FAIL: docker_api_swarm_test.go:292: DockerSwarmSuite.TestAPISwarmLeaderElection
01:52:59 
01:52:59 Creating a new daemon
01:52:59 [d33633282af82] waiting for daemon to start
01:52:59 [d33633282af82] daemon started
01:52:59 
01:52:59 Creating a new daemon
01:52:59 [d652ea0e2209d] waiting for daemon to start
01:52:59 [d652ea0e2209d] daemon started
01:52:59 
01:52:59 Creating a new daemon
01:52:59 [d2311585af671] waiting for daemon to start
01:52:59 [d2311585af671] daemon started
01:52:59 
01:52:59 [d33633282af82] Stopping daemon
01:52:59 [d33633282af82] exiting daemon
01:52:59 [d33633282af82] Daemon stopped
01:52:59 Waiting for election to occur...
01:52:59 assertion failed: error is not nil: Error response from daemon: rpc error: code = DeadlineExceeded desc = context deadline exceeded: [d652ea0e2209d] (*Daemon).GetNode: NodeInspectWithRaw("ly9njv6l2dcvh384ft0cyaz1c") failed
01:52:59 waited for 20.000971802s (out of 30s)
01:52:59 [d652ea0e2209d] Stopping daemon
01:52:59 [d652ea0e2209d] exiting daemon
01:52:59 [d652ea0e2209d] Daemon stopped
01:52:59 [d2311585af671] Stopping daemon
01:52:59 [d2311585af671] exiting daemon
01:52:59 [d2311585af671] Daemon stopped

...

02:15:17 FAIL: docker_cli_swarm_test.go:1129: DockerSwarmSuite.TestSwarmLockUnlockCluster
02:15:17 

@dani-docker
Copy link

The diff LGTM 👍
not sure why the tests are failing but also can't see any relation to the code change

@thaJeztah thaJeztah force-pushed the 19.03_bump_swarmkit branch from 82e026a to 1e98b22 Compare August 8, 2019 01:09
@thaJeztah
Copy link
Member Author

rebased to trigger CI (results were purged)

@thaJeztah thaJeztah force-pushed the 19.03_bump_swarmkit branch from 1e98b22 to 3b21817 Compare August 8, 2019 01:25
@thaJeztah
Copy link
Member Author

rebased on top of #313 to fix the build

@thaJeztah
Copy link
Member Author

This is all green now. I'll rebase once more because #313 was merged (to get rid of the extra commit in this PR). We can merge this one, once reviewed by a maintainer

Screenshot 2019-08-08 at 17 07 06

…3 branch)

full diff: moby/swarmkit@961ec3a...4fb9e96

included:

- moby/swarmkit#2873 [19.03 backport] Only update non-terminal tasks on node removal
  - backport of moby/swarmkit#2867 Only update non-terminal tasks on node removal

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah force-pushed the 19.03_bump_swarmkit branch from 3b21817 to ee64eae Compare August 8, 2019 15:09
@thaJeztah
Copy link
Member Author

I see that Jenkins in this repository is still using the Ubuntu 16.04 aufs and overlay workers;

Should we change those to 1804-overlay2 ?

oh, hm.. looks like we might not have 18.04; are these auto-scaling? if so should we switch them all to overlay?
https://jenkins.dockerproject.org/computer/

Copy link

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 37d9901 into docker-archive:19.03 Aug 9, 2019
@thaJeztah thaJeztah deleted the 19.03_bump_swarmkit branch August 9, 2019 09:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants