This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Revert tty changes #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts to a version of runc without the ONCLR cleared to not cause a regression with different clients using --tty. This also reverts the OPOST changes to the term package to support the initial change. Signed-off-by: Michael Crosby <crosbymichael@gmail.com> (cherry picked from commit a5e8383) Signed-off-by: Tibor Vass <tibor@docker.com>
This reverts to a version of runc without the ONCLR cleared to not cause a regression with different clients using --tty. This also reverts the OPOST changes to the term package to support the initial change. Signed-off-by: Michael Crosby <crosbymichael@gmail.com> (cherry picked from commit a5e8383) Signed-off-by: Tibor Vass <tibor@docker.com>
40 tasks
|
Confirmed removing And pulling in the changes that we missed out in our first attempt at the revert: #54 |
|
LGTM Tested with a darwin build pointed to an older version of a daemon and stuff works: |
docker-jenkins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Pass VERSION to engine static builds Upstream-commit: 453d9a2 Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Oct 11, 2018
[18.09] backport fix denial of service with large numbers in cpuset-cpus and cpuset-mems Upstream-commit: 4b8336f7cf091fd5c4742286bda1e34c45667d78 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 30, 2020
Pass VERSION to engine static builds
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
Revert tty changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picking moby/moby#33577 to both engine and cli.