This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
daemon: Remove daemon datastructure dump functionality #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sending SIGUSR1 to the daemon, it can crash because of a concurrent map access panic, showing a stack trace involving dumpDaemon. It appears it's not possible to recover from a concurrent map access panic. Since it's important that SIGUSR1 not be a destructive operation, sadly the best course of action I can think of is to remove this functionality. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com> (cherry picked from commit a4c68ee) Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
40 tasks
|
LGTM |
andrewhsu
pushed a commit
that referenced
this pull request
Dec 4, 2017
no need to detect arch for alpine image Upstream-commit: 33ee027 Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Sep 28, 2018
[18.09] backport: tweak bind mount errors Upstream-commit: e44436c31fce06f9ad69cbb325b781be54516d3e Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 30, 2020
no need to detect arch for alpine image Upstream-commit: 33ee027 Component: packaging
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 30, 2020
no need to detect arch for alpine image
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
daemon: Remove daemon datastructure dump functionality
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from: moby/moby#33598
When sending SIGUSR1 to the daemon, it can crash because of a concurrent
map access panic, showing a stack trace involving dumpDaemon. It appears
it's not possible to recover from a concurrent map access panic. Since
it's important that SIGUSR1 not be a destructive operation, sadly the
best course of action I can think of is to remove this functionality.
Signed-off-by: Aaron Lehmann aaron.lehmann@docker.com
(cherry picked from commit a4c68ee)
Signed-off-by: Eli Uriegas eli.uriegas@docker.com