This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
Check signal is unset before using user stopsignal #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where if a stop signal is set, and a user sends SIGKILL, `container.ExitOnNext()` is not set, thus causing the container to restart. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 114652a) Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
40 tasks
|
@cpuguy83 seeing this error on integration test run: |
|
Seeing error in windows test that is known to be flakey: |
|
LGTM |
|
LGTM after rebuilding again, the failed tests from before are no longer failing, taking as flakey |
andrewhsu
pushed a commit
that referenced
this pull request
Sep 19, 2017
Switch aarch64 images to arm64v8 Upstream-commit: a1debdb Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Sep 21, 2018
…ithDefaultAddressPoolInit [18.09] backport TestServiceWithDefaultAddressPoolInit: avoid panic Upstream-commit: ff9340ca2cc003d0829216524c6f96b98ce62f16 Component: engine
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 30, 2020
Switch aarch64 images to arm64v8 Upstream-commit: a1debdb Component: packaging
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Jan 30, 2020
Switch aarch64 images to arm64v8
silvin-lubecki
pushed a commit
to silvin-lubecki/docker-ce
that referenced
this pull request
Feb 3, 2020
Check signal is unset before using user stopsignal
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from: moby/moby#33335
This fixes an issue where if a stop signal is set, and a user sends
SIGKILL,
container.ExitOnNext()is not set, thus causing the containerto restart.
Signed-off-by: Brian Goff cpuguy83@gmail.com
(cherry picked from commit 114652a)
Signed-off-by: Eli Uriegas eli.uriegas@docker.com