This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
WIP [17.07] fix tests #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re-kicking the windows test, failed with a weird error: Possibly related to this: |
…i` instead of `rmi -f` Because now the cli will always return 0 for `rmi -f`. Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Because now the cli will always return 0 for `rmi -f`. Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
…TestUpdateWithNanoCPUs Signed-off-by: Victor Vieux <victorvieux@gmail.com>
Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
To fix tests: - DockerSwarmSuite.TestSwarmNetworkPluginV2 - DockerSwarmSuite.TestServiceLogs Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Signed-off-by: Victor Vieux <victorvieux@gmail.com>
dnephin
reviewed
Jul 26, 2017
| out, _, err := dockerCmdWithError("rmi", "-f", imgID) | ||
| // rmi -f should not delete image with running containers | ||
| out, _, err := dockerCmdWithError("rmi", imgID) | ||
| // rmi should not delete image with running containers |
There was a problem hiding this comment.
If we're interested in preserving the intent of this test I think the correct change is to check that this text is in stderr, but there is no error. It should continue to use -f
| @@ -243,7 +243,7 @@ func (s *DockerSuite) TestRmiContainerImageNotFound(c *check.C) { | |||
| dockerCmd(c, "rmi", "-f", imageIds[1]) | |||
|
|
|||
| // Try to remove the image of the running container and see if it fails as expected. | |||
| out, _, err := dockerCmdWithError("rmi", "-f", imageIds[0]) | |||
| out, _, err := dockerCmdWithError("rmi", imageIds[0]) | |||
Signed-off-by: Victor Vieux <victorvieux@gmail.com>
|
looks like @tiborvass's fix works |
|
I think the test fixes for I opened docker/cli#394 to track the problem. I can prepare a revert commit of you agree. |
8 tasks
|
LGTM |
|
no longer needed because 17.07 is eol |
docker-jenkins
pushed a commit
that referenced
this pull request
Aug 17, 2018
Merged with https://github.com/seemethere/unir Upstream-commit: ecfdd4c Component: packaging
docker-jenkins
pushed a commit
that referenced
this pull request
Dec 17, 2018
[18.09] libcontainerd: prevent exec delete locking Upstream-commit: 484a3c3ad0fdb59ab9bb83ef2ff79184e216313f Component: engine
akrasnov-drv
pushed a commit
to drivenets/docker-ce
that referenced
this pull request
Apr 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following tests:
Punting on:
Test verified by compiling cli from docker-ce 17.07 branch and using that when running test-integration-cli test from engine component of docker-ce 17.07 branch, e.g.