-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comments, but WIP
CHANGELOG.md
Outdated
|
||
### API & Client | ||
|
||
* Api: Update swagger.yaml for configs [moby/moby#34172](https://github.com/moby/moby/pull/34172) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is marked for 🍒 picking in 17.06 as well
CHANGELOG.md
Outdated
|
||
* Api: Update swagger.yaml for configs [moby/moby#34172](https://github.com/moby/moby/pull/34172) | ||
* Enable pprof/debug endpoints by default [moby/moby#32453](https://github.com/moby/moby/pull/32453) | ||
* Unexport subcommands [docker/cli#350](https://github.com/docker/cli/pull/350) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May not be worth mentioning, not a user facing change
CHANGELOG.md
Outdated
* Enable pprof/debug endpoints by default [moby/moby#32453](https://github.com/moby/moby/pull/32453) | ||
* Unexport subcommands [docker/cli#350](https://github.com/docker/cli/pull/350) | ||
- Fix filters displaying for docker search [docker/cli#331](https://github.com/docker/cli/pull/331) | ||
* Password stdin [docker/cli#271](https://github.com/docker/cli/pull/271) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passwords can now be passed using `STDIN` using the new `--password-stdin` flag on `docker login`
CHANGELOG.md
Outdated
* Unexport subcommands [docker/cli#350](https://github.com/docker/cli/pull/350) | ||
- Fix filters displaying for docker search [docker/cli#331](https://github.com/docker/cli/pull/331) | ||
* Password stdin [docker/cli#271](https://github.com/docker/cli/pull/271) | ||
* Don't attempt to remove unsupported resources on older daemon [docker/cli#277](https://github.com/docker/cli/pull/277) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is marked for 🍒 picking in 17.06
CHANGELOG.md
Outdated
- Fix filters displaying for docker search [docker/cli#331](https://github.com/docker/cli/pull/331) | ||
* Password stdin [docker/cli#271](https://github.com/docker/cli/pull/271) | ||
* Don't attempt to remove unsupported resources on older daemon [docker/cli#277](https://github.com/docker/cli/pull/277) | ||
* Return an empty stats if "container not found" [moby/moby#34004](https://github.com/moby/moby/pull/34004) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prevent `docker logs --no-stream` from hanging due to non-existing containers
CHANGELOG.md
Outdated
* Small refactor in system prune [docker/cli#341](https://github.com/docker/cli/pull/341) | ||
* Store container names in memdb [moby/moby#33886](https://github.com/moby/moby/pull/33886) | ||
* In the case of remounting with changed data, need to call mount [moby/moby#34077](https://github.com/moby/moby/pull/34077) | ||
* LCOW: Service VM lifetime changes [moby/moby#33969](https://github.com/moby/moby/pull/33969) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LCOW is all WIP, so can probably be removed
CHANGELOG.md
Outdated
* Store container names in memdb [moby/moby#33886](https://github.com/moby/moby/pull/33886) | ||
* In the case of remounting with changed data, need to call mount [moby/moby#34077](https://github.com/moby/moby/pull/34077) | ||
* LCOW: Service VM lifetime changes [moby/moby#33969](https://github.com/moby/moby/pull/33969) | ||
* Enable inspect exec if container is pause/restarting/non-running [moby/moby#32881](https://github.com/moby/moby/pull/32881) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix race condition between docker exec
and docker pause
CHANGELOG.md
Outdated
* In the case of remounting with changed data, need to call mount [moby/moby#34077](https://github.com/moby/moby/pull/34077) | ||
* LCOW: Service VM lifetime changes [moby/moby#33969](https://github.com/moby/moby/pull/33969) | ||
* Enable inspect exec if container is pause/restarting/non-running [moby/moby#32881](https://github.com/moby/moby/pull/32881) | ||
* Allow stopping of paused container [moby/moby#34027](https://github.com/moby/moby/pull/34027) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an enhancement, could be moved more "up"
CHANGELOG.md
Outdated
* Enable inspect exec if container is pause/restarting/non-running [moby/moby#32881](https://github.com/moby/moby/pull/32881) | ||
* Allow stopping of paused container [moby/moby#34027](https://github.com/moby/moby/pull/34027) | ||
* Devicemapper: rework logging and add --storage-opt dm.libdm_log_level [moby/moby#33845](https://github.com/moby/moby/pull/33845) | ||
* Devicemapper: Wait for device removal if deferredRemoval=true and deferredDeletion=… [moby/moby#33877](https://github.com/moby/moby/pull/33877) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Devicemapper: Prevent "device in use" errors if deferred removal is enabled, but not deferred deletion
CHANGELOG.md
Outdated
* Allow stopping of paused container [moby/moby#34027](https://github.com/moby/moby/pull/34027) | ||
* Devicemapper: rework logging and add --storage-opt dm.libdm_log_level [moby/moby#33845](https://github.com/moby/moby/pull/33845) | ||
* Devicemapper: Wait for device removal if deferredRemoval=true and deferredDeletion=… [moby/moby#33877](https://github.com/moby/moby/pull/33877) | ||
* Return prune data when context canceled [moby/moby#33979](https://github.com/moby/moby/pull/33979) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: here's where I left off
@vieux we need to add the |
CHANGELOG.md
Outdated
* Devicemapper: rework logging and add --storage-opt dm.libdm_log_level [moby/moby#33845](https://github.com/moby/moby/pull/33845) | ||
* Devicemapper: Prevent "device in use" errors if deferred removal is enabled, but not deferred deletion [moby/moby#33877](https://github.com/moby/moby/pull/33877) | ||
* Return prune data when context canceled [moby/moby#33979](https://github.com/moby/moby/pull/33979) | ||
- Fix docker cp dir with hard link [moby/moby#33956](https://github.com/moby/moby/pull/33956) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, looks like this needs to be merged into docker/cli first, so I'll remove this one for now
CHANGELOG.md
Outdated
* Fd leak and error handling [moby/moby#33713](https://github.com/moby/moby/pull/33713) | ||
- Fixing SIGSEGV when running containers [docker/cli#303](https://github.com/docker/cli/pull/303) | ||
- Fix plugin remove dir name after rename. [moby/moby#33944](https://github.com/moby/moby/pull/33944) | ||
* Make plugin removes more resilient to failure [moby/moby#33830](https://github.com/moby/moby/pull/33830) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included in 17.06.1
CHANGELOG.md
Outdated
- Fix run `docker rename <container-id> new_name` concurrently, the container will have multi names [moby/moby#33940](https://github.com/moby/moby/pull/33940) | ||
* Fd leak and error handling [moby/moby#33713](https://github.com/moby/moby/pull/33713) | ||
- Fixing SIGSEGV when running containers [docker/cli#303](https://github.com/docker/cli/pull/303) | ||
- Fix plugin remove dir name after rename. [moby/moby#33944](https://github.com/moby/moby/pull/33944) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Included in 17.06.1
CHANGELOG.md
Outdated
- Fixing SIGSEGV when running containers [docker/cli#303](https://github.com/docker/cli/pull/303) | ||
- Fix plugin remove dir name after rename. [moby/moby#33944](https://github.com/moby/moby/pull/33944) | ||
* Make plugin removes more resilient to failure [moby/moby#33830](https://github.com/moby/moby/pull/33830) | ||
* Ignore nonexistent containers when listing containers [moby/moby#33908](https://github.com/moby/moby/pull/33908) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix for master only (regression due to moby/moby#31273)
CHANGELOG.md
Outdated
- Fix plugin remove dir name after rename. [moby/moby#33944](https://github.com/moby/moby/pull/33944) | ||
* Make plugin removes more resilient to failure [moby/moby#33830](https://github.com/moby/moby/pull/33830) | ||
* Ignore nonexistent containers when listing containers [moby/moby#33908](https://github.com/moby/moby/pull/33908) | ||
* Do not error on relabel when relabel not supported [moby/moby#33831](https://github.com/moby/moby/pull/33831) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backported to 17.06.1
CHANGELOG.md
Outdated
* Make engine support cluster config event [moby/moby#34032](https://github.com/moby/moby/pull/34032) | ||
* Plugins on swarm [moby/moby#33575](https://github.com/moby/moby/pull/33575) | ||
* Refactor and UI changes to `swarm ca` command [docker/cli#213](https://github.com/docker/cli/pull/213) [docker/cli#207](https://github.com/docker/cli/pull/207) | ||
* Redact swarm spec CA signing cert for usability reasons [moby/moby#33712](https://github.com/moby/moby/pull/33712) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cherry-picked in 17.06.0
CHANGELOG.md
Outdated
* Sort swarm stacks and nodes using natural sorting [docker/cli#315](https://github.com/docker/cli/pull/315) | ||
* Make engine support cluster config event [moby/moby#34032](https://github.com/moby/moby/pull/34032) | ||
* Plugins on swarm [moby/moby#33575](https://github.com/moby/moby/pull/33575) | ||
* Refactor and UI changes to `swarm ca` command [docker/cli#213](https://github.com/docker/cli/pull/213) [docker/cli#207](https://github.com/docker/cli/pull/207) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docker/cli#207 was included in 17.06.1 and the refactor only has minimal user-facing changes; removing this one
CHANGELOG.md
Outdated
* Redact swarm spec CA signing cert for usability reasons [moby/moby#33712](https://github.com/moby/moby/pull/33712) | ||
* Only pass a join address when in the process of joining a cluster [moby/moby#33361](https://github.com/moby/moby/pull/33361) | ||
* Use scope=swarm for service related network inspect and revendor docker/docker [docker/cli#184](https://github.com/docker/cli/pull/184) | ||
* Limit max backoff delay to 2 seconds for GRPC connection [moby/moby#33483](https://github.com/moby/moby/pull/33483) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backported to 17.06.1
CHANGELOG.md
Outdated
* Only pass a join address when in the process of joining a cluster [moby/moby#33361](https://github.com/moby/moby/pull/33361) | ||
* Use scope=swarm for service related network inspect and revendor docker/docker [docker/cli#184](https://github.com/docker/cli/pull/184) | ||
* Limit max backoff delay to 2 seconds for GRPC connection [moby/moby#33483](https://github.com/moby/moby/pull/33483) | ||
* Do not clear swarm directory on `swarm init` and `swarm join` [moby/moby#33341](https://github.com/moby/moby/pull/33341) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cherry-picked in 17.06.0
CHANGELOG.md
Outdated
|
||
### Deprecation | ||
|
||
* Remove deprecated -e/--email flag from docker login [docker/cli#143](https://github.com/docker/cli/pull/143) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cherry-picked into 17.06.0
@vieux for some reason it didn't push to your branch, but you can take this commit; thaJeztah@19f70ad |
Signed-off-by: Victor Vieux <victorvieux@gmail.com>
LGTM |
* Devicemapper: Rework logging and add `--storage-opt dm.libdm_log_level` [moby/moby#33845](https://github.com/moby/moby/pull/33845) | ||
* Devicemapper: Prevent "device in use" errors if deferred removal is enabled, but not deferred deletion [moby/moby#33877](https://github.com/moby/moby/pull/33877) | ||
* Devicemapper: Use KeepAlive to prevent tasks being garbage-collected while still in use [moby/moby#33376](https://github.com/moby/moby/pull/33376) | ||
* Report inetermediate prune results if prune is cancelled [moby/moby#33979](https://github.com/moby/moby/pull/33979) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling: inetermediate -> intermediate
Merged with https://github.com/seemethere/unir Upstream-commit: 8c000e1 Component: packaging
ping @andrewhsu anything to add packaging wise ?
ping @thaJeztah