Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Commit

Permalink
Merge pull request #147 from seemethere/c
Browse files Browse the repository at this point in the history
Make ENGINE_IMAGE configurable for dockerd.json
Upstream-commit: 411a802
Component: packaging
  • Loading branch information
seemethere authored Aug 20, 2018
2 parents 6e4bcc8 + 3f276a5 commit d59e776
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion components/packaging/common/dockerd.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"image": "docker.io/docker/engine-community:${IMAGE_TAG}",
"image": "docker.io/${ENGINE_IMAGE}:${IMAGE_TAG}",
"namespace":"docker",
"args": [
"-s", "overlay",
Expand Down
3 changes: 2 additions & 1 deletion components/packaging/deb/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ RUN=docker run --rm -i \

SOURCE_FILES=containerd-proxy.tgz cli.tgz containerd-shim-process.tar docker.service dockerd.json
SOURCES=$(addprefix sources/, $(SOURCE_FILES))
ENGINE_IMAGE=docker/engine-community

IMAGE_TAG=nightly

Expand Down Expand Up @@ -147,6 +148,6 @@ sources/docker.service: ../systemd/docker.service

sources/dockerd.json: ../common/dockerd.json
mkdir -p $(@D)
sed 's/$${IMAGE_TAG}/$(IMAGE_TAG)/' $< > $@
sed -e 's!$${ENGINE_IMAGE}!$(ENGINE_IMAGE)!' -e 's/$${IMAGE_TAG}/$(IMAGE_TAG)/' $< > $@

# TODO: Figure out a sufficient offline solution
3 changes: 2 additions & 1 deletion components/packaging/rpm/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ RPMBUILD_FLAGS?=-ba\
--define '_origversion $(word 4, $(GEN_RPM_VER))' \
$(SPECS)
RUN?=$(RPMBUILD) rpmbuild-$@/$(ARCH) $(RPMBUILD_FLAGS)
ENGINE_IMAGE=docker/engine-community

SOURCE_FILES=containerd-proxy.tgz cli.tgz containerd-shim-process.tar docker.service dockerd.json
SOURCES=$(addprefix rpmbuild/SOURCES/, $(SOURCE_FILES))
Expand Down Expand Up @@ -111,6 +112,6 @@ rpmbuild/SOURCES/docker.service: ../systemd/docker.service

rpmbuild/SOURCES/dockerd.json: ../common/dockerd.json
mkdir -p $(@D)
sed 's/$${IMAGE_TAG}/$(IMAGE_TAG)/' $< > $@
sed -e 's!$${ENGINE_IMAGE}!$(ENGINE_IMAGE)!' -e 's/$${IMAGE_TAG}/$(IMAGE_TAG)/' $< > $@

# TODO: Figure out a sufficient offline solution

0 comments on commit d59e776

Please sign in to comment.