Improvement: Integrate Versions into Projects API #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reglim
changed the title
reglim
force-pushed
the
improvement/367-integrate-more-data-into-projects-endpoint
branch
2 times, most recently
from
9650282 to
7c11690
Compare
randombenj
approved these changes
Jan 11, 2023
There was a problem hiding this comment.
@fliiiix What is your stake on including all hidden versins by default in the api response?
reglim
force-pushed
the
improvement/367-integrate-more-data-into-projects-endpoint
branch
2 times, most recently
from
f1b4cc4 to
81f7f1c
Compare
Now we don't have to load any data for each project, greatly reducing the number of requests and improving responsiveness. We now also return hidden versions, but with the property "hidden" to distinguish them in the UI, which fixes a bug where you couldn't look at hidden versions because they weren't found, but they aren't returned by default. fixes: #367
reglim
force-pushed
the
improvement/367-integrate-more-data-into-projects-endpoint
branch
from
81f7f1c to
2d77299
Compare
reglim
deleted the
improvement/367-integrate-more-data-into-projects-endpoint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we don't have to load any data for each project, greatly reducing the number of requests and improving responsiveness.
We now also return hidden versions, but with the property "hidden" to distinguish them in the UI, which fixes a bug where you couldn't look at hidden versions because they weren't found.
fixes: #367