Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Icon-Upload Mime Type not checked properly #289

Closed
reglim opened this issue Oct 3, 2022 · 0 comments · Fixed by #290
Closed

Bugfix: Icon-Upload Mime Type not checked properly #289

reglim opened this issue Oct 3, 2022 · 0 comments · Fixed by #290

Comments

@reglim
Copy link
Contributor

reglim commented Oct 3, 2022

The mime type is not checked properly in icon-upload, which is why it sometimes fails even though the file is an image
reglim added a commit that referenced this issue Oct 3, 2022
@reglim
Fix(docat): Mime Type not checked properly
a1d5f92 
I added python-magic to check the actual bytes of the upload. I also had
to adapt the tests because of that.

Is also necessary for compatabilty with the new docatl upload-icon
feature.

fixes: #289
reglim added a commit that referenced this issue Oct 3, 2022
@reglim
Fix(docat): Icon-Upload Mime Type Check
f8918fc 
I added Python-Magic to do that. I also had to adapt the tests because
they succeeded even though the content was text not binary.

Is also required for the new docatl push-icon feature.

fixed: #289
@reglim reglim mentioned this issue Oct 3, 2022
Merged
@reglim reglim mentioned this issue Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix(docat): Icon-Upload Mime Type Check docat-org/docat
1 participant
@reglim