Implement dnsimple_domain_delegation resource
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 13, 2023 20:29
ghost
added
ghost
requested a review
from 
DXTimer
requested changes
Apr 19, 2023
|
QAd and the resource works exactly as expected. After the comments are addressed this should be good to go. |
Co-authored-by: Ivan Bakalov <ivan.bakalov@dnsimple.com>
Co-authored-by: Ivan Bakalov <ivan.bakalov@dnsimple.com>
Co-authored-by: Ivan Bakalov <ivan.bakalov@dnsimple.com>
added 3 commits
April 20, 2023 14:35
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a resource that will take control of a domain's delegation settings and allow management via Terraform. When the resource is destroyed, only the Terraform state is removed; the domain delegation is kept as is and will no longer be managed by Terraform.