Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transfer lock management to registered domain resource #143

Merged
merged 8 commits into from
Sep 1, 2023
Merged

Add transfer lock management to registered domain resource #143

merged 8 commits into from
Sep 1, 2023

Conversation

AGS4NO
Copy link
Contributor

@AGS4NO AGS4NO commented Aug 30, 2023 •
edited by DXTimer
Loading

Adds the ability to manage the registrar service domain transfer lock as part of the registered_domain resource

Belongs to https://github.com/dnsimple/dnsimple-business/issues/1728

Depends on dnsimple/dnsimple-go#147

Pre-Release Tasks

  • Update dnsimple-go version

@AGS4NO AGS4NO self-assigned this Aug 30, 2023
@AGS4NO AGS4NO marked this pull request as ready for review August 31, 2023 02:39
@AGS4NO AGS4NO requested a review from a team August 31, 2023 02:39
ghost
ghost reviewed Aug 31, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@DXTimer DXTimer self-requested a review August 31, 2023 05:37
DXTimer
DXTimer reviewed Aug 31, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
DXTimer
DXTimer approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@DXTimer DXTimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this, I have done QA and the changes work as expected. 💯

@DXTimer DXTimer requested a review from a user August 31, 2023 06:20
@DXTimer DXTimer merged commit df93bbf into main Sep 1, 2023
7 checks passed
@DXTimer DXTimer deleted the enhancement/registered-domain-transfer-lock branch September 1, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DXTimer DXTimer DXTimer approved these changes

Assignees

@AGS4NO AGS4NO

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AGS4NO @DXTimer