Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for key-data interface creating delegation signer records #210

Merged
merged 4 commits into from
Oct 5, 2021
Merged

Add support for key-data interface creating delegation signer records #210

merged 4 commits into from
Oct 5, 2021

Conversation

jacegu
Copy link
Contributor

@jacegu jacegu commented Oct 1, 2021

This PR:

  • Updates the fixtures from dnsimple-developer repo to reflect the latest changes to our DNSSEC-related APIs.
  • Adds new fields to affected structs.
  • Updates documentation on affected endpoints.
  • Updates some tests to make more clear what data is being passed in.

I was able to verify the changes by enabling DNSSEC on one of our testing .BE domains.

@jacegu
Change: Refresh TLD fixtures
c502755
@jacegu
Change: Refresh delegation signer record fixtures
c560da5
@jacegu
Change: Tld struct includes dnssec interface type
8a85ac0
@jacegu
Change: Update DelegationSignerRecord structs
ea929c1 
DelegationSignerRecordInput has been updated along all the corresponding
docs. The usage in the tests has also been tweaked to specify the keys
of the dictionary that are being passed in for clarity.
@jacegu jacegu self-assigned this Oct 1, 2021
@jacegu jacegu marked this pull request as ready for review October 1, 2021 09:24
@jacegu jacegu requested review from a team, DXTimer and AGS4NO and removed request for a team October 1, 2021 09:24
@jacegu jacegu added the ready-for-review Pull requests that are ready to be reviewed by other team members. label Oct 1, 2021
@jacegu jacegu merged commit dacca20 into main Oct 5, 2021
@jacegu jacegu deleted the dnssec-key-data-support branch October 5, 2021 14:18
jacegu added a commit that referenced this pull request Oct 6, 2021
@jacegu
Update CHANGELOG.md
fa8fa96 
Should have been part of #210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DXTimer DXTimer DXTimer approved these changes

@AGS4NO AGS4NO AGS4NO approved these changes

Assignees

@jacegu jacegu

Labels
enhancement ready-for-review Pull requests that are ready to be reviewed by other team members.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacegu @DXTimer @AGS4NO