Export returned values #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weppos
added
enhancement
aeden
approved these changes
Apr 30, 2020
This was referenced May 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #54 I decided to change the method signatures to not export the response values. At a distance of few years, I believe this was probably not a good idea.
While it works in most cases, it makes more complex to implement testing. An example is when you need to create tests that will construct pagination.
https://github.com/kubernetes-sigs/external-dns/blob/master/provider/dnsimple_test.go#L105-L128
golint is also quite vocal about how it may be annoying to not export the values.
I'm rolling back the changes in this PR. The good news is that since we forced the callers to never reference the value directly, this change should have very limited impact on anyone using the client.
Anyways, I'm working on several breaking changes as part of the next release, so it's a good time to include this PR as well.