Remove premium_price attribute from registrar order responses #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a parameter allowed for register/transfer/renew.
weppos
added
enhancement
4 tasks
aeden
previously requested changes
Dec 30, 2017
dnsimple/registrar.go
Outdated
| @@ -122,6 +121,9 @@ type DomainRegisterRequest struct { | |||
| // Set to true to enable the auto-renewal of the domain. | |||
| // Default to true. | |||
| EnableAutoRenewal bool `json:"auto_renew,omitempty"` | |||
| // Required as confirmation of the price, only if the domain is premium. | |||
| // Default to true. | |||
There was a problem hiding this comment.
I don't understand why this says "Default to true" when this is a string value.
dnsimple/registrar.go
Outdated
| @@ -175,6 +176,9 @@ type DomainTransferRequest struct { | |||
| // Set to true to enable the auto-renewal of the domain. | |||
| // Default to true. | |||
| EnableAutoRenewal bool `json:"auto_renew,omitempty"` | |||
| // Required as confirmation of the price, only if the domain is premium. | |||
| // Default to true. | |||
There was a problem hiding this comment.
I don't understand why this says "Default to true" when this is a string value.
dnsimple/registrar.go
Outdated
| @@ -239,6 +242,9 @@ type domainRenewalResponse struct { | |||
| type DomainRenewRequest struct { | |||
| // The number of years | |||
| Period int `json:"period"` | |||
| // Required as confirmation of the price, only if the domain is premium. | |||
| // Default to true. | |||
There was a problem hiding this comment.
I don't understand why this says "Default to true" when this is a string value.
|
I fixed it @aeden |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dnsimple/dnsimple-developer#155