Add support for the new Query Volume API endpoint #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DXTimer
reviewed
Jan 25, 2024
DXTimer
reviewed
Jan 25, 2024
dnsimple/dns_analytics.go
Outdated
| // Query gets DNS Analytics data for an account | ||
| // | ||
| // See https://developer.dnsimple.com/v2/dns_analytics/#query | ||
| func (s *DnsAnalyticsService) Query(ctx context.Context, accountID string, options *ListOptions) (*DnsAnalyticsResponse, error) { |
There was a problem hiding this comment.
Generally, we try to match the endpoint call method with the operation ID in the OpenAPI spec, I could not find an OpenAPI spec entry for this endpoint so I could not see how it compares. In case they do not match we should maybe include an example in the readme.
There was a problem hiding this comment.
👍 We will be updating the OpenAPI spec in the following days. Let's come back to this then.
DXTimer
approved these changes
Jan 25, 2024
ggalmazor
force-pushed
the
change/support_query_volume_endpoint
branch
from
566c652
to
4866d73
Compare
DXTimer
approved these changes
Jan 30, 2024
- Response payloads will encode it as a string - We will require an int64 as query parameter for convenience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163
In this PR: