Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement billing charges API #156

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Implement billing charges API #156

merged 5 commits into from
Nov 3, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 24, 2023 •
edited by ghost
Loading

This adds support for the listCharges API.

Belongs to https://github.com/dnsimple/dnsimple-business/issues/1763

@ghost ghost added the enhancement New feature, enhancement or code changes, not related to defects label Oct 24, 2023
@ghost ghost self-assigned this Oct 24, 2023
@ghost ghost marked this pull request as ready for review October 25, 2023 22:15
@ghost ghost self-requested a review October 25, 2023 22:15
AGS4NO
AGS4NO approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@AGS4NO AGS4NO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending feedback on leaving the amounts as strings

@AGS4NO AGS4NO assigned AGS4NO and unassigned ghost Nov 1, 2023
@DXTimer DXTimer merged commit ccfeab5 into main Nov 3, 2023
5 checks passed
@DXTimer DXTimer deleted the feature/billing-api branch November 3, 2023 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AGS4NO AGS4NO

Labels
enhancement New feature, enhancement or code changes, not related to defects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DXTimer @AGS4NO