-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to activate and deactivate DNS services for a zone #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
enhancement
New feature, enhancement or code changes, not related to defects
label
Aug 10, 2023
ghost
self-requested a review
August 10, 2023 06:59
ghost
self-assigned this
Aug 10, 2023
ghost
requested a review
from DXTimer
August 10, 2023 11:27
DXTimer
requested changes
Aug 11, 2023
ghost
requested a review
from DXTimer
August 11, 2023 05:55
DXTimer
reviewed
Aug 11, 2023
ghost
requested a review
from DXTimer
August 11, 2023 06:04
DXTimer
approved these changes
Aug 11, 2023
ghost
deleted the
enhancement/manage-zone-resolution
branch
August 11, 2023 06:19
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements dnsimple/dnsimple-developer#502 which allows for the management of DNS resolution for a particular zone.
This PR also updates the
EmailForward
with new attributes replacingTo
andFrom
for email forward resource creation. See the changelog for more information.Belongs to https://github.com/dnsimple/dnsimple-external-integrations/issues/3
Belongs to https://github.com/dnsimple/dnsimple-external-integrations/issues/2