Implement registrar methods for Domain Prices API #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new client method for our Domain Prices API: - Registrar.GetDomainPrices - Retrieves the prices for a domain. It also includes if the domain is premium or not in the response.
duduribeiro
added
enhancement
OleMchls
approved these changes
Apr 12, 2021
|
Specs are broken. Please address them first, then re-add for review. |
The work to fix the cause of the broken specs are being done at #104. Maybe we can allow 1.5 to fail for now until we finish the Transfer-Encoding work. wdyt @DXTimer @ggalmazor ? |
san983
reviewed
Apr 13, 2021
Co-authored-by: Santiago Traversa <san983@users.noreply.github.com>
weppos
reviewed
Apr 20, 2021
| Data *DomainPrice `json:"data"` | ||
| } | ||
|
|
||
| func (s *RegistrarService) GetDomainPrices(ctx context.Context, accountID string, domainName string) (*DomainPriceResponse, error) { |
There was a problem hiding this comment.
You are missing the docs here. It breaks the lint.
➜ dnsimple-go git:(implement_domain_prices) ✗ golint ./...
dnsimple/registrar.go:110:1: exported method RegistrarService.GetDomainPrices should have comment or be unexported
There was a problem hiding this comment.
@weppos thanks!
shouldn't we add this on CI? thanks
There was a problem hiding this comment.
Yes, it would be great. Sadly, it's a bit complicated:
- I tried to add a
Makefilein the past b7733b8, sadly once you add aMakefileTravis will rely entirely on it and you will need a non trivial amount of customization to make the build pass in both module and non-module versions. Things would be easier if we would only use module-aware versions (1.11 or above). golintis not enough to break the build. It's a highly recommended standard. We could add it asgolint ./...in the travis.yml file, but it would cause the build to break if anything is invalid (and right now we have one lint warning). The current warning is actually a false positive due to a naming conflict between the webook package and the Webhook as result of the Webhook API. I am not sure how to ignore this as golint doesn't have a way to address false positives. We should probably upgrade togolangci-lintwhich instead does.
weppos
reviewed
Apr 20, 2021
weppos
approved these changes
Apr 20, 2021
Co-authored-by: Simone Carletti <weppos@gmail.com>
This was referenced May 20, 2021
This was referenced Sep 13, 2021
Closed
This was referenced Sep 27, 2021
Closed
This was referenced Oct 15, 2021
Closed
Closed
Closed
This was referenced Oct 26, 2021
Closed
This was referenced Nov 3, 2021
Open
Open
This was referenced Jan 10, 2022
Open
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new client method for our Domain Prices API:
It also includes if the domain is premium or not in the response.