Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bulk Install: Resolved various build and watch issues #5989

Merged
merged 2 commits into from
Mar 2, 2024
Merged

Bulk Install: Resolved various build and watch issues #5989

merged 2 commits into from
Mar 2, 2024

Conversation

david-poindexter
Copy link
Contributor

Summary

This PR is part of ongoing work for #5920.

It aims to:

  • Resolve all MSBuild issues for the new Bulk Install module.
  • Resolve all packaging issues within the MSBuild system for DNN.
  • Ensure the front-end project is picked up for the yarn workspace, and thus lerna.
  • Ensure the front-end placeholder component is rendered in the module's view.html file.

image

@david-poindexter david-poindexter added this to the 10.0.0 milestone Mar 1, 2024
@david-poindexter david-poindexter self-assigned this Mar 1, 2024
valadas
valadas approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@valadas
Copy link
Contributor

valadas commented Mar 1, 2024

Oh, except this:

image

I believe it may be caused by not have xml documentation turned on in release mode maybe... Ping me up if that is not clear

@david-poindexter
Copy link
Contributor Author

Oh, except this:

image

I believe it may be caused by not have xml documentation turned on in release mode maybe... Ping me up if that is not clear

I just pushed a commit to see if this fixes it. Great catch!

@david-poindexter david-poindexter changed the title Resolved various build and watch issues Bulk Install: Resolved various build and watch issues Mar 2, 2024
@valadas
Copy link
Contributor

valadas commented Mar 2, 2024

It fixed, it, merging...

@valadas valadas merged commit 074603e into dnnsoftware:feature/bulk-install Mar 2, 2024
4 checks passed
@david-poindexter david-poindexter deleted the bulk-install-msbuild branch March 2, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valadas valadas valadas approved these changes

@bdukes bdukes Awaiting requested review from bdukes

Assignees

@david-poindexter david-poindexter

Labels
Area: Platform > Modules Effort: Medium Priority: High Status: Review Type: Feature
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@david-poindexter @valadas