Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Newtonsoft.Json to 13.0.1 #5168

Merged

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Jun 28, 2022

Summary

This PR upgrades DNN's dependency on Newtonsoft.Json from 10.x to 13.0.1.

This includes the following changes from their changelog:

  • Types that implement ISerializable but don't have [SerializableAttribute] are not serialized using ISerializable
  • Changed JsonProperty.MemberConverter to obsolete
  • Changed camel casing logic for all caps words to not leave last character capitalized
  • Changed enum serialization in dictionary keys to use EnumMemberAttribute
  • JTokenReader now uses JsonReader.DateTimeZoneHandling setting for date values
  • Excluded TargetSite when serializing Exceptions without SerializableAttribute
  • Changed StringEnumConverter.ctor(bool camelCaseText) to obsolete
  • Changed StringEnumConverter.CamelCaseText to obsolete
  • JsonReader and JsonSerializer MaxDepth defaults to 64

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @bdukes - THANK YOU! 🎉

Looks like the build is delayed a bit in running - still in queue. So, barring no build issues, this looks good to me.

This was referenced Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to latest json.NET version 12 from 10
3 participants