Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some conflicts with ASP.NET dependencies #4743

Merged
merged 4 commits into from
Jul 13, 2021

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Jul 13, 2021

Summary

The original PR #4716 missed a few pieces.

  1. Need to include the WebMatrix DLLs in the new AspNetWebPages package, they were also updated.
  2. Need to include DotNetNuke.Web.Mvc in the AspNetMvc package, since it relies on a particular version of MVC (another option would be adjusting the version range on the binding redirect, but that would only fix subsequent upgrades).
  3. Move the HTTP module for MVC into the AspNetMvc package, since the pieces it relies on aren't included until after install.

@bdukes bdukes modified the milestones: 10.0.0, 9.10.0 Jul 13, 2021
@valadas
Copy link
Contributor

valadas commented Jul 13, 2021

Thank you soooo much for looking into this!

I will test a clean install and upgrade after it builds.
Just one little thing, where the removals of newlines in the comments in release.config and development.config intentional ?

@bdukes
Copy link
Contributor Author

bdukes commented Jul 13, 2021

No, the whitespace changes were done automatically by my editor, I've reverted those changes.

@david-poindexter
Copy link
Contributor

david-poindexter commented Jul 13, 2021

I'll be on my computer again in a bit - I can also do a test as soon as the build finishes. Thanks @bdukes 🎉

@bdukes
Copy link
Contributor Author

bdukes commented Jul 13, 2021

I successfully installed the package and successfully upgraded from 9.9.1

@david-poindexter
Copy link
Contributor

Awesome @bdukes - I just downloaded and will test as well.

Copy link
Contributor

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo hoo - great success! Thank you @bdukes 🎉

Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, a clean install worked fine for me too.

@valadas valadas merged commit 4a18099 into dnnsoftware:release/9.10.0 Jul 13, 2021
@bdukes bdukes deleted the aspnet-deps branch July 16, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants