Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce snupkg format for NuGet #4608

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Conversation

bdukes
Copy link
Contributor

@bdukes bdukes commented Apr 14, 2021

Summary

We're currently producing "legacy" symbols packages for NuGet, which is causing issues with automated pushing of NuGet packages (the ordering matters of whether you push the non-symbols or symbols package first and we're getting a conflict error).

This PR tells NuGet to produce the newer symbols package format, *.snupkg, which should resolve that issue.

I've had unrelated issues getting my build to finish locally, so this change still needs confirmation from the PR build.

@bdukes bdukes added this to the 9.9.2 milestone Apr 14, 2021
Since this package doesn't include any source, it can't include symbols.
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mitchelsellers mitchelsellers merged commit 2e68b5d into dnnsoftware:develop Apr 14, 2021
@mitchelsellers mitchelsellers deleted the snupkg branch April 14, 2021 20:14
@valadas valadas modified the milestones: 9.9.2, 9.10.0 Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants