Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed for anti-pattern Obsolete #4349

Merged
merged 5 commits into from
Dec 11, 2020

Conversation

mitchelsellers
Copy link
Contributor

Summary

DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
DNN Platform/Library/Security/PortalSecurity.cs Outdated Show resolved Hide resolved
mitchelsellers and others added 2 commits December 8, 2020 14:32
Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Code layout fixes

Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@valadas
Copy link
Contributor

valadas commented Dec 8, 2020

Oh, one project that has "Treat warnings as errors" on is breaking the build... I gonna try to take a look at that...

@valadas
Copy link
Contributor

valadas commented Dec 9, 2020

Oh, I can't push to that remote, let me try from the browser as a suggestion...

@valadas
Copy link
Contributor

valadas commented Dec 9, 2020

I could not do a browser suggestion because it's not in a file that is part of this PR, so I sent you a PR @mitchelsellers

Resolves a build error from using deprecated enum value.
@valadas
Copy link
Contributor

valadas commented Dec 9, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@valadas
Copy link
Contributor

valadas commented Dec 9, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@valadas
Copy link
Contributor

valadas commented Dec 9, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bdukes bdukes merged commit 673c59e into dnnsoftware:develop Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants