Fix Localization Issues #4265
Merged
Fix Localization Issues #4265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdukes
force-pushed
the
fixlocalization
branch
from
868cb58 to
c2cb40c
Compare
|
I've rebased these changes on the release branch |
bdukes
approved these changes
Oct 30, 2020
mitchelsellers
requested changes
Oct 30, 2020
|
Strange the pipeline failed because of Dnn.ClientDependency, I gonna try to run it again to see if that is a fluke... |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
Looks like it's failing because MyGet is down... |
|
Looks like MyGet is back up, firing up a new build |
|
/azp run |
|
No pipelines are associated with this pull request. |
I updated my local repo with your changes but now we have 1000+ changes ... Maybe you'll need to rebase again. |
valadas
requested changes
Oct 31, 2020
bdukes
force-pushed
the
fixlocalization
branch
from
da5d855 to
2be936a
Compare
bdukes
force-pushed
the
fixlocalization
branch
from
2be936a to
a1c5c15
Compare
|
I've cherry-picked from your merge commit, @donker, and then rebased again on the release branch |
valadas
approved these changes
Oct 31, 2020
mitchelsellers
approved these changes
Oct 31, 2020
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During testing we discovered that the thread locale was not set correctly when switching languages. This PR addresses that issue.