Cleaned up UserProfile Class #4195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
valadas
commented
Oct 15, 2020
valadas
commented
- Resolves many stylecop warnings in UserProfile
- Makes constants for retrieving profile properties obsolute and re-implements them as private constants
- Updated some upstream classes to use IPortalSettings instead of PortalSettings
- Implemented automated stylecop fixes on many other files in the same project
- Resolves many stylecop warnings in UserProfile - Makes constants for retrieving profile properties obsolute and re-implements them as private constants - Updated some upstream classes to use IPortalSettings instead of PortalSettings - Implemented automated stylecop fixes on many other files in the same project
bdukes
reviewed
Oct 15, 2020
There was a problem hiding this comment.
Thanks! We just need to add a deprecated PortalSettings overload for that public method, otherwise it's all good (with a couple of XML doc suggestions).
I've verified this produced 37,378 warnings while the previous build produced 37,507 warnings (i.e. this removes 129 warnings).
DNN Platform/Library/Services/Tokens/PropertyAccess/IPropertyAccess.cs
Outdated
Show resolved
Hide resolved
DNN Platform/Library/Services/Tokens/PropertyAccess/IPropertyAccess.cs
Outdated
Show resolved
Hide resolved
bdukes
reviewed
Oct 15, 2020
Yeah, so we are almost done here 🤣 |
… one with IPortalSettings
…ccess.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
…ccess.cs Co-authored-by: Brian Dukes <bdukes@engagesoftware.com>
….Platform into user-profile-cleanup
|
I did some analysis on the build log, and if we ignore the SA16xx documentation warnings and the CS0618 obsolete warnings, we're almost there with only a little over 10,000 warnings left. |
mitchelsellers
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.