Introduce MailAttachment class #4187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support multiple mail providers, this introduces a new MailAttachment class for use by the MailProvider API. This decoupling from System.Net.Mail.Attachment will give more flexibility when implementing new providers, such as MailKit.
mitchelsellers
approved these changes
Oct 13, 2020
bdukes
added a commit
to bdukes/Dnn.Platform
that referenced
this pull request
Aug 31, 2021
This functionality was inexplicably removed in b3e066f dnnsoftware#4187 Includes fixes originally from dnnsoftware#2900 (1b44e1d) Fixes dnnsoftware#2899
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the work done by @meetmandeep in #4156 and extracts the
MailAttachmentclass, so that we can process the switch to MailKit separately (i.e. for a later release).