Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mergeable to not allow merging of PRs with Future:... milestone #4127

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Update mergeable to not allow merging of PRs with Future:... milestone #4127

merged 1 commit into from
Sep 25, 2020

Conversation

david-poindexter
Copy link
Contributor

Summary

This PR updates mergeable to not allow merging of PRs that contain a Future: milestone.

@david-poindexter david-poindexter added this to the 9.7.3 milestone Sep 25, 2020
@david-poindexter david-poindexter self-assigned this Sep 25, 2020
mitchelsellers
mitchelsellers approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@mitchelsellers mitchelsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks sir!

valadas
valadas approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@valadas
Copy link
Contributor

valadas commented Sep 25, 2020

I hereby officially approve this PR :)

@valadas valadas merged commit 1639966 into dnnsoftware:develop Sep 25, 2020
@valadas valadas modified the milestones: 9.7.3, 9.8.0 Oct 7, 2020
@david-poindexter david-poindexter deleted the mergeable-milestone branch May 31, 2021 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valadas valadas valadas approved these changes

@mitchelsellers mitchelsellers mitchelsellers approved these changes

Assignees

@david-poindexter david-poindexter

Labels
Type: Maintenance
Projects
None yet
Milestone
9.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@david-poindexter @valadas @mitchelsellers