-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusts build scripts to build CKEditor #4105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed one commit to add StyleCop.Analyzers to the packages.config
for the CKEditorProvider. Once the build is done this can be merged 👍🏻
@bdukes I thought we had a main packages.config and projects would just reference the common packages folder, am I wrong about that? |
Yeah, each package has its own |
Hmm, ok, thanks, I guess it makes sense if you only build one project. I thought for some reason there was a single packages.config to make it easier to bump dependency verisons... |
This is a follow up PR on #4096 which merged CKEditor into this repository. This PR adjusts the build to no longer fetch it externally and build it as the rest of the project.