Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusts build scripts to build CKEditor #4105

Merged
merged 12 commits into from
Sep 21, 2020

Conversation

valadas
Copy link
Contributor

@valadas valadas commented Sep 20, 2020

This is a follow up PR on #4096 which merged CKEditor into this repository. This PR adjusts the build to no longer fetch it externally and build it as the rest of the project.

@valadas valadas added this to the 9.7.3 milestone Sep 20, 2020
Copy link
Contributor

@bdukes bdukes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed one commit to add StyleCop.Analyzers to the packages.config for the CKEditorProvider. Once the build is done this can be merged 👍🏻

@valadas
Copy link
Contributor Author

valadas commented Sep 21, 2020

@bdukes I thought we had a main packages.config and projects would just reference the common packages folder, am I wrong about that?

@bdukes
Copy link
Contributor

bdukes commented Sep 21, 2020

Yeah, each package has its own packages.config file (except for the couple of newer projects that use <ProjectReference /> inside the csproj file). There's a shared packages folder in the root (next to the sln), but each project needs its own list of NuGet packages (in addition to the references).

@bdukes bdukes merged commit e9abb9e into dnnsoftware:develop Sep 21, 2020
@valadas
Copy link
Contributor Author

valadas commented Sep 21, 2020

Hmm, ok, thanks, I guess it makes sense if you only build one project. I thought for some reason there was a single packages.config to make it easier to bump dependency verisons...

@valadas valadas modified the milestones: 9.7.3, 9.8.0 Oct 7, 2020
@valadas valadas deleted the ckeditor-build branch April 14, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants