-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace momentjs with dayjs for Servers.Web #4104
Replace momentjs with dayjs for Servers.Web #4104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me and saw it working fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update the license documentation to include this new third party to keep compliant.
My suggestion is a bit beyond the scope of this PR but what do you guys think if we use https://classic.yarnpkg.com/en/docs/cli/licenses/ to generate all the mentions for the stuff we grab using npm. If we are in agreement, I can work on a PR that would do this on build... It would no cover stuff we use without npm but that would be a lot less maintenance for what does. |
Possibly the generate disclaimer option could work. But for the interim id like to get it added here the normal way. |
@mitchelsellers yes, the license stuff is on my list. This is the first of many PRs to switch from moment.js to dayjs. Do you want the license mention to be added to this specific PR? Also, I have seen license information in multiple places, so at this point I am not clear where it should be based on the usage context. @valadas I really like your idea and it would really help to have this automated like this. To me, the sooner we do that, the better off we'll be covered for attribution. |
Just needs to be in the master list of licenses for the project. No specific place for this PR. I just don’t want to accidentally release with a new third party and not have the license included. |
@mitchelsellers I just pushed a commit to put it where I think it needs to be. Let me know if that is not the correct place. |
Summary
This is the first of several PRs for #3875. This one replaces
momentjs
withdayjs
forServers.Web
in Dnn.AdminExperience.