Fixes services framework usage in permission grid for the file manager #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-poindexter
approved these changes
Aug 25, 2020
|
@donker the main change here from your fork is the addition of dnnSf.js in the app/globals folder and the changes in babel config, eslint config and package.json |
donker
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@donker has been working integrating the persmissions grid into the new resource manager and had some issues with the persona bar specific services implementation integration.
This PR brings a copy of that implementation that should work inside or outside the persona bar.
I have tested that it does read the permissions properly and user search is also working. However there is still an issue saving those settings. But this PR brings us closer to have folder permissions working.
Thanks @david-poindexter and @mitchelsellers for co-coding on this one too.