Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource manager layout with older Themes #4928

Closed
2 of 3 tasks
Timo-Breumelhof opened this issue Dec 2, 2021 · 0 comments · Fixed by #4929
Closed
2 of 3 tasks

Resource manager layout with older Themes #4928

Timo-Breumelhof opened this issue Dec 2, 2021 · 0 comments · Fixed by #4929

Comments

@Timo-Breumelhof
Copy link
Contributor

Timo-Breumelhof commented Dec 2, 2021

Description of bug

I noticed that on "older" skins the Resource manager looked a bit weird.
See:

image

After some research I found that those Themes are not forcing

CSS:
box-sizing: border-box;

And due to this the Search box moves to the next line.

This can be fixed using this CSS:

.rm-container *{
	box-sizing: border-box;
}

As in many cases it's not feasible to switch an older Theme to use border-box.

Steps to reproduce

See: https://youtu.be/2-aCW80VxWQ

List the precise steps to reproduce the bug:

  1. Copy the attached Theme to your test installation
    40F-Test.zip
  2. Set the Theme as the theme for a test page
  3. Place the Resource manager in the "ContentPane"
  4. See the issue
  5. Now move the module to the "BorderBoxPane" and see it's fixed.
    (this pane has CSS that forces it's content to border-box)

image

Current behavior

Layout issue

Expected behavior

No layout issue :-)

Screenshots

See above

Affected version

  • 10.00.00 alpha build
  • 09.10.02 release candidate
  • 09.10.01 latest supported release
@Timo-Breumelhof Timo-Breumelhof changed the title Resource manager layout issue when used with certain older Themes Resource manager layout with older Themes Dec 2, 2021
Timo-Breumelhof added a commit to Timo-Breumelhof/Dnn.Platform that referenced this issue Dec 2, 2021
bdukes pushed a commit that referenced this issue Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant