Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set the value from Player #1

Open
wants to merge 4 commits into
base: definedata-view
Choose a base branch
from

Conversation

saintentropy
Copy link

@saintentropy saintentropy commented Mar 18, 2024

Purpose

This code change does the following:

  1. Lets the DataIO node to be set as an input node
  2. Adds the option to pass data in from the DynamoPlayer vs only the upstream nodes.
  3. Fix VM to make this version of inputs possible

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@@ -440,6 +440,9 @@ private bool VerifyGraphSyncData(IEnumerable<NodeModel> nodes)
{
if (!node.IsInputNode) continue;

//We also don't want any nodes that do have input ports or where derived from custom nodes.
if (node.InPorts.Any() || node.IsCustomFunction) continue;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test for this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants