Style : 포즈피드 화면 구현 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guesung
reviewed
Aug 5, 2023
guesung
reviewed
Aug 5, 2023
guesung
reviewed
Aug 5, 2023
src/app/feed/page.tsx
Outdated
| @@ -1,3 +1,27 @@ | |||
| 'use client'; | |||
There was a problem hiding this comment.
page 컴포넌트는 client component로 할 경우, import하여 사용하는 모든 하위 컴포넌트가 client component가 되어버립니다.
page.tsx는 server component로 살리고, 자식 컴포넌트에서 server component로 사용할 것과 client component로 사용할 것을 나누는 것이 필요해 보입니다.
There was a problem hiding this comment.
https://nextjs.org/docs/getting-started/react-essentials#patterns
공식 문서 한 번 읽어보시는 거 추천드려요 !
guesung
reviewed
Aug 5, 2023
src/app/feed/components/Filter.tsx
Outdated
| <div className="fixed left-0 right-0 top-116 flex h-56 items-center bg-white px-20"> | ||
| <button className="bg-sub-white flex items-center gap-8 rounded-8 px-16 py-9"> | ||
| <h5 id="subtitle-2">필터</h5> | ||
| <Image src={ICON.carat.down} alt={'▾'} width={16} height={16} /> |
There was a problem hiding this comment.
문자열 props로 통일하는 방식을 통일해야 할 거 같아요
props를 넘길 때 문자열일 경우 " "만으로도 전달이 되어서 {' '}에서 { }는 제거하는 거 어떤가요 ??
There was a problem hiding this comment.
재가 매번 Image prop 작성하는게 귀찮아서 Image 만 작성하고 solve problems? 버튼으로 없는 props를 자동으로 작성하는데요, 이 과정에서 저렇게 뜨는 것 같습니다... vsc 자동완성인데 설정으로 바꿀 수 있다면 바꿔보고 아니라면 직접 쓰는 방식으로 통일하겠습니다..!
guesung
reviewed
Aug 5, 2023
guesung
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 왜 PR을 올렸나요?
💁 무엇이 어떻게 바뀌나요?
📆 작업 예정인 것이 있나요 ?
💬 리뷰어분들께
api 연결 후에는 삭제 예정이니 무시해주세요 ㅎㅎ