fix : Issue 사항 해결 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seondal
reviewed
Sep 9, 2023
| <IconButton size="large" onClick={() => router.back()}> | ||
| <Image src="/icons/close.svg" width={24} height={24} alt="back" /> | ||
| </IconButton> | ||
| <Link href="/feed" scroll={false}> |
There was a problem hiding this comment.
엇 이 클로즈 버튼 컴포넌트는 메뉴에서도 쓰이는거라 feed로 고정하면 안되지 않을까요...?!
There was a problem hiding this comment.
흠 그렇군요
카카오톡 공유하기로 detail페이지를 타고 들어왔을 때, x버튼을 누르면 이전으로 갈 수가 없어서 feed로 라우팅을 하였습니다.
우선 이 컴포넌트는 router.back()을 default로 하고, detail페이지는 따로 만드는 게 좋겠군요.
There was a problem hiding this comment.
오 detail로 타고 들어왔을 때를 생각 못했네요...!
속성으로 목적지를 받는게 더 좋을 것 같아요 !!
seondal
requested changes
Sep 9, 2023
seondal
approved these changes
Sep 9, 2023
seondal
requested changes
Sep 9, 2023
There was a problem hiding this comment.
http://localhost:3000/detail/36
이미지 상세보기 눌러서 이미지 모달 열었을 때 세로가 좀 긴 이미지는 세로길이가 작은 화면에서 잘리는 현상이 발생합니당..! 스크롤을 넣거나 이미지 높이가 화면 크기를 넘지 않게 조정해야할 것 같아요
+) 해결해써요 0b1c57c
seondal
approved these changes
Sep 9, 2023
|
저도 z-index이슈 찾긴했는데 원인을 찾지 못했는데 해결하셧군요 ..! 최곱니당 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 왜 PR을 올렸나요?
💁 무엇이 어떻게 바뀌나요?
📆 작업 예정인 것이 있나요 ?
#46 에서 아직 해결하지 못한 것들
💬 리뷰어분들께