Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor : 메뉴 페이지 위주 #42

Merged
merged 16 commits into from
Sep 8, 2023
Merged

refactor : 메뉴 페이지 위주 #42

merged 16 commits into from
Sep 8, 2023

Conversation

seondal
Copy link
Member

@seondal seondal commented Sep 5, 2023

💡 왜 PR을 올렸나요?

  • fix
  • refactor

💁 무엇이 어떻게 바뀌나요?

  1. 북마크 아이콘 색
  2. gitignore
  3. close button 컴포넌트화
  4. 메뉴모달 컴포넌트화
  5. 메뉴페이지 연결
  6. 메뉴페이지 디자인

📆 작업 예정인 것이 있나요 ?

  • 포즈픽 이미지 비율 이슈

💬 리뷰어분들께

PR이 연속적으로 올라옵니다..!

@seondal seondal added 🛠 Fix 버그 수정 ♻️ Refactor 코드 리팩토링, 폴더구조 변경 등 기능상 차이가 없을 때 💄 Style 화면 그리기, 스타일링 labels Sep 5, 2023
@seondal seondal self-assigned this Sep 5, 2023
@seondal seondal requested a review from guesung as a code owner September 5, 2023 06:10
Copy link
Collaborator

@guesung guesung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Comment on lines +6 to +8
import { IMAGE } from '@/constants/image';
import Image from 'next/image';

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vscode에서 이 부분 혹시 노란 색 밑줄로 보이시나요 ??

lint 적용이 안되고 있는 거 같은데, 터미널 옆에 출력에서 eslint 혹은 prettier 잘 적용되고 있는 지 확인해보시겠어용 !

만약 에러가 발생하고 있다면 ctrl + shift + p에서 Eslint server Restart 한 번 해보세용

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 저는 밑줄이 안보이긴 합니다 !

src/app/layout.tsx Outdated Show resolved Hide resolved
@seondal seondal requested a review from guesung September 7, 2023 13:15
@seondal seondal merged commit 90bdab8 into develop Sep 8, 2023
@seondal seondal deleted the feat-infinite-scroll branch September 8, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠 Fix 버그 수정 ♻️ Refactor 코드 리팩토링, 폴더구조 변경 등 기능상 차이가 없을 때 💄 Style 화면 그리기, 스타일링
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants