Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/final #36

Merged
merged 19 commits into from
Aug 26, 2023
Merged

Hotfix/final #36

merged 19 commits into from
Aug 26, 2023

Conversation

seondal
Copy link
Member

@seondal seondal commented Aug 25, 2023

πŸ’‘ μ™œ PR을 μ˜¬λ Έλ‚˜μš”?

  • hotfix

πŸ’ 무엇이 μ–΄λ–»κ²Œ λ°”λ€Œλ‚˜μš”?

QA 반영

πŸ“† μž‘μ—… μ˜ˆμ •μΈ 것이 μžˆλ‚˜μš” ?

  • 데λͺ¨μ˜μƒ 촬영 및 λ°œν‘œ μ€€λΉ„

πŸ’¬ λ¦¬λ·°μ–΄λΆ„λ“€κ»˜

λΉ λ₯Έ 머지 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€μ•„ !

@seondal seondal added πŸ›  Fix 버그 μˆ˜μ • πŸ’„ Style ν™”λ©΄ 그리기, μŠ€νƒ€μΌλ§ labels Aug 25, 2023
@seondal seondal self-assigned this Aug 25, 2023
@seondal seondal requested a review from guesung as a code owner August 25, 2023 18:27
Comment on lines 47 to 48
<div className="relative">
<img
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ImageλŠ” Nextjsμ—μ„œ μ œκ³΅ν•˜λŠ” μ΅œμ ν™”λœ νƒœκ·Έμž…λ‹ˆλ‹€.

imgλ₯Ό μ‚¬μš©ν•˜λŠ” μ΄μœ κ°€ λ¬΄μ—‡μΈκ°€μš” ??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 Imageκ°€ μ΅œμ ν™” νƒœκ·ΈμΈκ±° μ••λ‹ˆλ‹Ή..
λ‹€λ§Œ λ„€νŠΈμ›Œν‚Ή 탭을 보면 Image νƒœκ·ΈλŠ” image?apiλ₯Ό μ‚¬μš©ν•˜κ³  img νƒœκ·ΈλŠ” λ°”λ‘œ 파일λͺ…μœΌλ‘œ λ°›μ•„μ˜€λ”λΌκ΅¬μš”! ν¬μ¦ˆν”Όλ“œκ°€ 아직 λ‘œλ”© λΆ„κΈ°μ²˜λ¦¬λ₯Ό μ•ˆν•΄μ„œ 이미지 λ³΄μ—¬μ§€λŠ” 속도가 μ€‘μš”ν•˜λ‹€κ³  νŒλ‹¨λ˜μ–΄ imgνƒœκ·Έλ₯Ό μ‚¬μš©ν–ˆμŠ΅λ‹ˆλ‹€

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ·Έλ ‡κ΅°μš”. λ°œν‘œ 후에 쑰금 더 λ…Όμ˜ν•˜λ©΄ 쒋을 것 κ°™λ„€μš”

μ•Œκ² μŠ΅λ‹ˆλ‹€ -!

@@ -9,7 +9,9 @@ export default function BottomFixedDiv({
className,
}: StrictPropsWithChildren<BottomFixedDivProps>) {
return (
<div className={`fixed inset-x-0 bottom-20 mx-auto max-w-440 px-20 ${className}`}>
<div
className={`fixed inset-x-0 bottom-0 mx-auto max-w-440 bg-white px-20 pb-20 pt-10 ${className}`}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ›ΉμœΌλ‘œ μ ‘μ†ν–ˆμ„ λ•Œ λ„€λΉ„κ²Œμ΄μ…˜ λ°”κ°€ 있기 λ•Œλ¬Έμ— 이미 λ²„νŠΌμ΄ μœ„λ‘œ μ˜¬λΌμ™€ μžˆλŠ” μƒνƒœμž…λ‹ˆλ‹€.

UXλ₯Ό 더 ν—€μΉ˜λŠ” 뢀뢄이라 생각해, pb-20은 μ œκ±°ν•˜λŠ” 게 쒋을 κ±° κ°™μ•„μš”.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ—‡ μ•„λ‹™λ‹ˆλ‹€ μžμ„Ένžˆ λ³΄μ‹œλ©΄ bottom20 λŒ€μ‹  bottom0 pb20을 μ μš©ν–ˆμ–΄μš”! λ°”ν…€λ²„νŠΌ μ•„λž˜λ‘œ 투λͺ…ν•˜κ²Œ 뒀에 λ‚΄μš©λ“€μ΄ λ³΄μ΄λŠ”κ²ƒ λ•Œλ¬Έμ— μˆ˜μ •ν–ˆμ–΄μš”γ… γ…œ μƒμ„ΈνŽ˜μ΄μ§€ 확인 λΆ€νƒλ“œλ €μš”... 흑.. μ΄μœ κ°€ μžˆμ–΄μ„œ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€ πŸ₯Ί

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„ν•˜ κ·Έλ ‡κ΅°μš” ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€ !!

Copy link
Collaborator

@guesung guesung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

@guesung guesung merged commit ecc381f into develop Aug 26, 2023
@guesung guesung deleted the hotfix/final branch August 26, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ›  Fix 버그 μˆ˜μ • πŸ’„ Style ν™”λ©΄ 그리기, μŠ€νƒ€μΌλ§
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants