Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring : QA 반영 - 3차 #31

Merged
merged 3 commits into from
Aug 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added public/images/main.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
15 changes: 0 additions & 15 deletions public/images/menu/icon-button.svg

This file was deleted.

Binary file removed public/images/sample.png
Binary file not shown.
Binary file removed public/images/sample_talk.png
Binary file not shown.
2 changes: 1 addition & 1 deletion public/sw.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/app/(Main)/talk/components/TalkSection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import lottieTalkAfterClick from '#/lotties/talk_after_click.json';
import lottieTalkBeforeClick from '#/lotties/talk_before_click.json';
import { usePoseTalkQuery } from '@/apis';
import { BottomFixedButton } from '@/components/Button';
import { Spacing } from '@/components/Spacing';
import useLoading from '@/hooks/useLoading';

export default function TalkSection() {
Expand Down Expand Up @@ -36,6 +37,8 @@ export default function TalkSection() {
<section className="flex flex-col items-center">
<h1 className="text-center">{talkWord}</h1>

<Spacing size={10} />

{isFirstLoading && (
<Lottie
loop
Expand Down
50 changes: 26 additions & 24 deletions src/app/(Sub)/detail/[id]/components/DetailSection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export default function DetailSection({ poseId }: DetailSectionProps) {
};

return (
<div className="flex flex-col items-center">
<div>
{sourceUrl && (
<Link
href={'https://' + sourceUrl}
Expand All @@ -43,29 +43,31 @@ export default function DetailSection({ poseId }: DetailSectionProps) {
↗ 이미지 출처
</Link>
)}
<div className="relative h-520 w-400">
<Image
src={imageKey}
fill
alt="detailImage"
className="cursor-pointer"
onClick={() =>
open(({ exit }) => (
<Popup>
<Image
src={imageKey}
alt="enlargementImage"
priority
loading="eager"
onClick={exit}
width={500}
height={440}
className="cursor-pointer"
/>
</Popup>
))
}
/>
<div className="flex justify-center">
<div className="relative h-520 w-440">
<Image
src={imageKey}
fill
alt="detailImage"
className="cursor-pointer"
onClick={() =>
open(({ exit }) => (
<Popup>
<Image
src={imageKey}
alt="enlargementImage"
priority
loading="eager"
onClick={exit}
width={500}
height={440}
className="cursor-pointer"
/>
</Popup>
))
}
/>
</div>
</div>
<div className="flex flex-wrap gap-10 px-20 py-12">
{tagAttributes?.split(',').map((tag, index) => <Tag key={index} name={tag} />)}
Expand Down
Binary file modified src/app/favicon.ico
Binary file not shown.
53 changes: 22 additions & 31 deletions src/app/layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,47 +5,38 @@ import '../../styles/typography.css';
import Script from 'next/script';

import { OverlayProvider } from '@/components/Overlay/OverlayProvider';
import { GA_ID } from '@/constants';
import { BASE_SITE_URL, GA_ID } from '@/constants';
import QueryProvider from '@/provider/QueryProvider';
import RecoilContextProvider from '@/provider/RecoilContextProvider';

import type { Metadata } from 'next';

const DEFAULT_OG_TITLE = 'PosePicker';
const DEFAULT_OG_DESC = '포토부스에서 고민하는 당신을 위한 포즈 추천';
const DEFAULT_OG_IMAGE = '/images/main.png';

export const metadata: Metadata = {
title: 'PosePicker',
description: '포토부스에서 고민하는 당신을 위한 포즈 추천',
openGraph: {
title: 'PosePicker',
description: 'PosePicker FE by @guesung, @seondal',
url: 'https://pose-picker.vercel.app/', // 웹사이트 URL
siteName: 'PosePicker',
images: [
{
url: '', // 이미지 URL
width: 1920,
height: 1080,
},
],
locale: 'ko-KR',
type: 'website',
metadataBase: new URL(BASE_SITE_URL),
title: {
template: `${DEFAULT_OG_TITLE} / %s `,
default: DEFAULT_OG_TITLE,
},
robots: {
index: true,
follow: true,
googleBot: {
index: true,
follow: true,
'max-video-preview': -1,
'max-image-preview': 'large',
'max-snippet': -1,
},
description: DEFAULT_OG_DESC,
openGraph: {
title: DEFAULT_OG_TITLE,
description: DEFAULT_OG_DESC,
images: [DEFAULT_OG_IMAGE],
},
twitter: {
title: 'PosePicker',
card: 'summary_large_image',
title: DEFAULT_OG_TITLE,
description: DEFAULT_OG_DESC,
images: [DEFAULT_OG_IMAGE],
},
icons: {
shortcut: '/favicon.ico',
viewport: {
width: 'device-width',
initialScale: 1,
maximumScale: 1,
userScalable: false,
},
manifest: '/manifest.json',
themeColor: '#ffffff',
Expand Down
2 changes: 1 addition & 1 deletion src/constants/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export const BASE_API_URL = process.env.NEXT_PUBLIC_API_URL;
export const BASE_SITE_URL = process.env.NEXT_PUBLIC_SITE_URL;
export const BASE_SITE_URL = process.env.NEXT_PUBLIC_SITE_URL ?? 'https://www.posepicker.site';
export const KAKAO_KEY = process.env.NEXT_PUBLIC_KAKAO_KEY;
export const GA_ID = process.env.NEXT_PUBLIC_GA_ID;