feat : 북마크 페이지 #16
Merged
feat : 북마크 페이지 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guesung
reviewed
Aug 18, 2023
Comment on lines
+8
to
+11
| title={'포즈를 보관해 보세요!'} | ||
| text={`북마크 버튼으로 포즈를 보관할 수 있어요.\n포즈피드에서 멋진 포즈를 찾아 보관해 보세요.`} | ||
| button={'포즈피드 바로가기'} | ||
| path={'/feed'} |
guesung
reviewed
Aug 18, 2023
| import FilterSheet from './components/FilterSheet'; | ||
| import PhotoList from './components/PhotoList'; | ||
|
|
||
| export default function Feed() { | ||
| return ( | ||
| <> | ||
| <Filter /> | ||
| <div className="pt-72"> |
There was a problem hiding this comment.
p4)
pt-72보다, Spacing컴포넌트 사용하는 거 어떤가요 ??
guesung
reviewed
Aug 18, 2023
| } | ||
|
|
||
| export default function EmptyCase(props: EmptyCase) { | ||
| const { title, text, button, path } = props; |
There was a problem hiding this comment.
p3)
컨벤션을 통일해야 할 것 같아요.
PrimaryButton등 다른 컴포넌트에서는 인자에서 구조분해하여 할당받았는데, 이 방식으로 통일하는 거 어떤가요?
export default function EmptyCase( { title, text, button, path } : EmptyCase) { }이런 식으로요 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 왜 PR을 올렸나요?
💁 무엇이 어떻게 바뀌나요?
📆 작업 예정인 것이 있나요 ?
💬 리뷰어분들께
PR #15 에서 판 브랜치입니다. 해당 pr 코드리뷰 및 머지 먼저 부탁드려요☺️