Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLOOM-006] 알림속성 개발 #13

Merged
merged 13 commits into from
Jul 27, 2024
Merged

[BLOOM-006] 알림속성 개발 #13

merged 13 commits into from
Jul 27, 2024

Conversation

Dompoo
Copy link
Collaborator

@Dompoo Dompoo commented Jul 25, 2024 •
edited
Loading

How

  • 알림관련 속성을 Embeddable로 작성한 후 식물 엔티티에 Embedded 하였습니다.
  • dto->entity 변환 로직을 서비스에서 구현하였습니다.

Result

image

@Dompoo Dompoo added the 🌱 feat Suggest a new feature or enhancement label Jul 25, 2024
@Dompoo Dompoo self-assigned this Jul 25, 2024
@Dompoo Dompoo linked an issue Jul 25, 2024 that may be closed by this pull request
[feat] 알림 속성 개발 #6
Closed
@Dompoo Dompoo requested a review from stophwan July 25, 2024 17:00
stophwan
stophwan approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@stophwan stophwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트만 확인부탁드려요! 자세한건 이후 이야기해보고 일단 승인 해두겠습니다!

src/main/kotlin/dnd11th/blooming/domain/entity/Alarm.kt Outdated Show resolved Hide resolved
@Dompoo
Copy link
Collaborator Author

Dompoo commented Jul 26, 2024

  • 알림 관련 칼럼을 Embeddable로 처리하였습니다.
  • 기존 entity가 dto에 의존하는 코드(dto -> entity 변환로직)을 서비스 내부로 이동했습니다. 추후에 변환과정에서 비즈니스 로직(가이드를 기반으로 기본 물주기 주기를 넣기 등)이 필요하다고 생각했습니다.
  • 테스트를 수정했습니다.

@Dompoo Dompoo changed the title [BLOOM-006] 알림 엔티티 개발 [BLOOM-006] 알림속성 개발 Jul 27, 2024
@Dompoo Dompoo merged commit b2e1043 into main Jul 27, 2024
2 checks passed
@Dompoo Dompoo deleted the feat/alarm branch August 11, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stophwan stophwan stophwan approved these changes

Assignees

@Dompoo Dompoo

Labels
🌱 feat Suggest a new feature or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 알림 속성 개발
2 participants
@Dompoo @stophwan