Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLOOM-128] 이미지 삭제 api 수정 #129

Merged
merged 1 commit into from
Sep 21, 2024
Merged

[BLOOM-128] 이미지 삭제 api 수정 #129

merged 1 commit into from
Sep 21, 2024

Conversation

Dompoo
Copy link
Collaborator

@Dompoo Dompoo commented Sep 20, 2024 •
edited
Loading

How

  • Path Variable 대신에 Request Body를 통해 동시에 여러 이미지 id들을 받을 수 있도록 했습니다.
  • 해당 이미지들을 동시에 삭제합니다.

Result

  • 이제 이미지 삭제 api에서 여러 이미지를 동시에 삭제할 수 있게 되었습니다.

Resolves #128

@Dompoo Dompoo added the 🔨 fix Request a fix for an existing feature label Sep 20, 2024
@Dompoo Dompoo self-assigned this Sep 20, 2024
@Dompoo Dompoo requested a review from stophwan as a code owner September 20, 2024 14:50
stophwan
stophwan approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@stophwan stophwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@Dompoo Dompoo merged commit 2c6c4a5 into main Sep 21, 2024
2 checks passed
@stophwan stophwan deleted the fix/myplant-image-delete branch September 25, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stophwan stophwan stophwan approved these changes

Assignees

@Dompoo Dompoo

Labels
🔨 fix Request a fix for an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] 이미지 삭제 api 수정
2 participants
@Dompoo @stophwan