Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Publish Script #85

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Fix Publish Script #85

merged 2 commits into from
Aug 23, 2024

Conversation

miraexhoi
Copy link
Member

πŸ“Ž κ΄€λ ¨ Issue 번호

πŸ“„ μž‘μ—… λ‚΄μš© μš”μ•½

  • EC2 μΈμŠ€ν„΄μŠ€ 변경에 λ”°λ₯Έ username μˆ˜μ •
  • cors μ„€μ • μΆ”κ°€

πŸ™‹πŸ» 주의 깊게 확인해야 ν•˜λŠ” μ½”λ“œ

x

πŸ“„ κ°œμ„  사항 OR μ°Έκ³  사항

x

@miraexhoi miraexhoi added fix κΈ°λŠ₯ λ³€κ²½ μ‹œ build 인프라 κ΄€λ ¨ μž‘μ—… μ‹œ labels Aug 22, 2024
@miraexhoi miraexhoi requested a review from apptie August 22, 2024 23:40
@miraexhoi miraexhoi self-assigned this Aug 22, 2024
@miraexhoi miraexhoi changed the title !hotfix :: add cors setting and change username Fix Publish Script Aug 22, 2024
Copy link
Collaborator

@apptie apptie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€
ν•„μš”ν•œ λΆ€λΆ„ μˆ˜μ • λΆ€νƒλ“œλ¦½λ‹ˆλ‹€

Comment on lines 25 to 26
echo " allowed-origin: allowed-origin" >> ./src/main/resources/application-prod.yml
echo " max-age: 2400" >> ./src/main/resources/application-prod.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν•„μˆ˜ 🚨

  1. ν•΄λ‹Ή 뢀뢄은 github secret으둜 κ΄€λ¦¬ν•˜κΈ°λ‘œ ν–ˆλ˜ 것 같은데 μ΄λ ‡κ²Œ 직접 μΆ”κ°€ν•˜λŠ” μ΄μœ κ°€ μžˆμ„κΉŒμš”?
  2. allowed-origin은 이 λ¦¬μ†ŒμŠ€λ₯Ό μ ‘κ·Όν•˜λŠ” 것이 ν—ˆμš©λœ μΆœμ € url을 μž…λ ₯ν•΄μ•Ό ν•˜κΈ° λ•Œλ¬Έμ— allowed-origin을 κ·ΈλŒ€λ‘œ λ„£λŠ” 것이 μ•„λ‹ˆλΌ ν”„λ‘ νŠΈμ—”λ“œμ—μ„œ μš”μ²­ν•˜λŠ” url(둜컬인 경우 http://localhost:3000)을 μž…λ ₯ν•΄μ•Ό ν•©λ‹ˆλ‹€
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„ν•˜ μ΄ν•΄ν–ˆμŠ΅λ‹ˆλ‹€ cfcb451
ν”„λ‘ νŠΈ 아직 배포 μ•ˆ 된걸둜 μ•ŒκΈ° λ•Œλ¬Έμ— http://localhost:3000 넣어두도둝 ν•˜κ² μŠ΅λ‹ˆλ‹€ ~

@miraexhoi miraexhoi requested a review from apptie August 23, 2024 02:42
Copy link
Collaborator

@apptie apptie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€

@miraexhoi miraexhoi merged commit 060859d into main Aug 23, 2024
1 check passed
@miraexhoi miraexhoi deleted the hotfix/#84 branch August 23, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build 인프라 κ΄€λ ¨ μž‘μ—… μ‹œ fix κΈ°λŠ₯ λ³€κ²½ μ‹œ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

!hotfix :: fix backend-publish file
2 participants