Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Polaroid 컴포넌트 제작 #53

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Conversation

easyhyun00
Copy link
Collaborator

🧩 이슈 번호

✅ 작업 사항

  • 기존 LetterAccordion 에 있던 Polaroid 를 컴포넌트로 분리했어요.
image image

👩‍💻 공유 포인트 및 논의 사항

  • Polaroid 사용방법
    • imgUrl : 이미지 주소이며 필수값 입니다.
    • topPosition : 기존 15rem에서 입력한 수 만큼 rem 단위로 top 위치가 변경됩니다.
    • leftPosition: 기존 1rem에서 입력한 수 만큼 rem 단위로 left 위치가 변경됩니다.
image

@easyhyun00 easyhyun00 added the ✨ Feature 기능 개발 label Jan 31, 2024
@easyhyun00 easyhyun00 self-assigned this Jan 31, 2024
Copy link

github-actions bot commented Jan 31, 2024

🚀 Storybook Preview 보러가기: https://65a6c73d536a3c43b7c5c9bb-ieinpyybif.chromatic.com/
🚀 React Preview 보러가기: https://dnd-10th-4-frontend-m42wxlvvb-bbearcookie.vercel.app

Copy link
Member

@bbearcookie bbearcookie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요~ 😊👍
Polaroid 컴포넌트로 분리되어서 외부에서 합성해서 사용하기 좋겠네요!! 👍

@@ -0,0 +1,33 @@
import type { Meta, StoryObj } from '@storybook/react';
// import { css } from '@emotion/react';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석이 남아있었네요!

@easyhyun00 easyhyun00 merged commit a3f7be3 into main Jan 31, 2024
7 checks passed
@easyhyun00 easyhyun00 deleted the feat/#49/polaroid branch January 31, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 기능 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polaroid 컴포넌트
2 participants