Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’„ design: Button μŠ€νƒ€μΌμ— λ””μžμΈ 토큰 반영 #46

Merged
merged 8 commits into from
Jan 30, 2024

Conversation

bbearcookie
Copy link
Member

@bbearcookie bbearcookie commented Jan 29, 2024

🧩 이슈 번호

βœ… μž‘μ—… 사항

  • ν”Όκ·Έλ§ˆμ˜ 컬러 νŒ”λ ˆνŠΈμ— μΆ”κ°€λœ primary 색상 3가지λ₯Ό μƒμˆ˜λ‘œ μ •λ¦¬ν–ˆμ–΄μš”.
  • Button μ»΄ν¬λ„ŒνŠΈμ— 적용된 λ””μžμΈ 토큰을 기반으둜 속성을 μ •λ¦¬ν–ˆμ–΄μš”.
    • 기쑴의 투λͺ…ν•œ λ²„νŠΌ μ†μ„±μ˜ 이름을 λ³€κ²½ν–ˆμ–΄μš”.
      • primary -> semi-transparent
      • primary-unaccent -> semi-transparent-unaccent
  • hover 색상을 μΆ”κ°€ν•˜κ³  μ§€ν˜„λ‹˜μ΄ IconButton에 μ μš©ν•΄μ£Όμ…¨λ˜ μŠ€νƒ€μΌμ„ ν™œμš©ν•˜μ—¬ active 에 μ μš©ν•΄λ³΄μ•˜μ–΄μš”.

λ³€κ²½λœ μŠ€ν† λ¦¬ 뢁

  • Button
  • Navbar

πŸ‘©β€πŸ’» 곡유 포인트 및 λ…Όμ˜ 사항

Button μŠ€ν† λ¦¬λΆ

image

병합 μˆœμ„œ: main <- feat/#43/text-design-token <- feat/#45/button-design-token

Copy link

πŸš€ Storybook Preview λ³΄λŸ¬κ°€κΈ°: https://65a6c73d536a3c43b7c5c9bb-cfgqvrkwlx.chromatic.com/
πŸš€ React Preview λ³΄λŸ¬κ°€κΈ°: https://sea-of-my-heart-ja3kfer7e-dnd-sea-of-my-heart.vercel.app

@easyhyun00
Copy link
Collaborator

기쑴의 투λͺ…ν•œ λ²„νŠΌ μ†μ„±μ˜ 이름을 λ³€κ²½ν–ˆμ–΄μš”.

primary 보닀 semi-transparent κ°€ 더 μ™€λ‹Ώλ„€μš”! 저도 μ°Έκ³ ν•˜κ² μŠ΅λ‹ˆλ‹€.

Copy link
Collaborator

@easyhyun00 easyhyun00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve ν•©λ‹ˆλ‹€!

@easyhyun00 easyhyun00 merged commit 881fe45 into feat/#43/text-design-token Jan 30, 2024
9 checks passed
@easyhyun00 easyhyun00 deleted the feat/#45/button-design-token branch January 30, 2024 05:21
bbearcookie added a commit that referenced this pull request Jan 30, 2024
* πŸ’„ design: Text μŠ€νƒ€μΌμ— λ””μžμΈ 토큰별 정리

* πŸ’„ design: λ³€κ²½λœ Text μŠ€νƒ€μΌμ— 따라 μŠ€ν† λ¦¬λΆ μž¬μž‘μ„±

* πŸ’„ design: Button μŠ€νƒ€μΌμ— λ””μžμΈ 토큰 반영 (#46)

* πŸ“¦ chore: primary κ΄€λ ¨ 색상 μƒμˆ˜ 정리

* πŸ’„ design: Button μ»΄ν¬λ„ŒνŠΈμ— λ””μžμΈ 토큰 적용 및 size 속성 μΆ”κ°€

* πŸ’„ design: Button μŠ€ν† λ¦¬λΆμ— μƒˆλ‘œμš΄ variant 적용

* πŸ’„ design: Navbar μŠ€ν† λ¦¬λΆμ— λ²„νŠΌμ˜ μƒˆλ‘œμš΄ variant 적용

* πŸ’„ design: active νŠΈλžœμ§€μ…˜μ΄ disabled μ—μ„œλŠ” λ‚˜νƒ€λ‚˜μ§€ μ•Šλ„λ‘ μˆ˜μ •

* πŸ’„ design: Button μŠ€ν† λ¦¬λΆμ— size, disabled prop μΆ”κ°€

* πŸ“¦ chore: preview.yml λŒ€μƒ λΈŒλžœμΉ˜μ— feat/** μΆ”κ°€

* πŸ“ style: BottomSheet의 button에 semi-transparent 속성 적용
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature κΈ°λŠ₯ 개발
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants