Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”จ refactor: ์ฝ”๋“œ ์Šคํ”Œ๋ฆฌํŒ… ๋ฐ ์„ฑ๋Šฅ ํ–ฅ์ƒ ์ž‘์—… #314

Merged
merged 5 commits into from
May 10, 2024

Conversation

bbearcookie
Copy link
Member

@bbearcookie bbearcookie commented May 7, 2024

๐Ÿงฉ ์ด์Šˆ ๋ฒˆํ˜ธ

โœ… ์ž‘์—… ์‚ฌํ•ญ

์ด์Šˆ ์ด๋ฆ„์€ ๋ชจ๋ฐ”์ผ ํผํฌ๋จผ์Šค ๊ฐœ์„ ์ด์—ˆ์ง€๋งŒ.. ์›Œ๋‚™ ๋‚ฎ๊ฒŒ ๋‚˜์™€์„œ PC ๊ธฐ์ค€์œผ๋กœ ์ž‘์—…ํ–ˆ์–ด์š” ๐Ÿ˜…

  • png ์ด๋ฏธ์ง€ ์• ์…‹์„ webp ํ™•์žฅ์ž๋กœ ๋ณ€ํ™˜ํ•˜์—ฌ ์šฉ๋Ÿ‰ ๊ฐ์†Œ
    • squoosh ์—์„œ ํ€„๋ฆฌํ‹ฐ 100%๋ฅผ ๊ทธ๋Œ€๋กœ ์œ ์ง€ํ•œ ์ฑ„ ๋ณ€ํ™˜ํ–ˆ์–ด์š”.
  • ์›น ํฐํŠธ preload ์ ์šฉ
  • Sentry ์— tree shaking ์ ์šฉ
  • ์ง€์—ญ ๋กœ๋”ฉ UI์˜ ์˜๋ฏธ๊ฐ€ ํฌ๊ฒŒ ์—†๋˜ ๋ถ€๋ถ„์˜ Suspense๋ฅผ ์ œ๊ฑฐํ•˜๊ณ  ์ „์—ญ์— ๋กœ๋”ฉ UI ์œ„์ž„

๐Ÿ‘ฉโ€๐Ÿ’ป ๊ณต์œ  ํฌ์ธํŠธ ๋ฐ ๋…ผ์˜ ์‚ฌํ•ญ

๊ธฐ์กด vs ๋ณ€๊ฒฝ ํ›„

lighthouse๋ฅผ ๋Œ๋ฆด ๋•Œ๋งˆ๋‹ค ์•ฝ๊ฐ„์˜ ์˜ค์ฐจ๊ฐ€ ์žˆ๊ธด ํ•˜์ง€๋งŒ, ํ‰๊ท  LCP๊ฐ€ 16%์ •๋„ ๋‹จ์ถ•๋˜์—ˆ์–ด์š”.
(์ถ”ํ›„์— ๋” ์ค„์—ฌ๋ด๋„ ์ข‹๊ฒ ๋„ค์š”!)

ํผํฌ๋จผ์Šค

์ฝ”๋“œ ์Šคํ”Œ๋ฆฌํŒ…๊ณผ ๊ด€๋ จํ•ด์„œ

์ฒ˜์Œ์— ๋ผ์šฐํŒ… ๊ฒฝ๋กœ ๋‹จ์œ„๋กœ ์ฝ”๋“œ ์Šคํ”Œ๋ฆฌํŒ…์„ ํ–ˆ์—ˆ๋Š”๋ฐ ์˜คํžˆ๋ ค ์ ์ˆ˜๊ฐ€ ๋‚ฎ์•„์ง€๋Š” ๊ฒฝ์šฐ๋„ ์žˆ๋”๋ผ๊ตฌ์š”..
๊ทธ๋ž˜์„œ ์šฐ์„  ๋ผ์ด๋ธŒ๋Ÿฌ๋ฆฌ๋งŒ ์ ์šฉํ–ˆ์–ด์š”.

@bbearcookie bbearcookie added the ๐Ÿ”จ Refactor ๋ฆฌํŒฉํ† ๋ง ์ž‘์—… label May 7, 2024
@bbearcookie bbearcookie self-assigned this May 7, 2024
@bbearcookie bbearcookie requested a review from easyhyun00 as a code owner May 7, 2024 10:03
Copy link

github-actions bot commented May 7, 2024

๐ŸŽฎ React Preview ๋ณด๋Ÿฌ๊ฐ€๊ธฐ: https://dnd-10th-4-frontend-cl44sudlg-bbearcookies-projects.vercel.app
โฐ ๋ฐฐํฌ ์ผ์‹œ: Tue May 07 2024 19:04:57 GMT+0900

Copy link

github-actions bot commented May 7, 2024

๐Ÿš€ Storybook Preview ๋ณด๋Ÿฌ๊ฐ€๊ธฐ: https://65a6c73d536a3c43b7c5c9bb-ziudraqrpc.chromatic.com/
โฐ ๋ฐฐํฌ ์ผ์‹œ: Tue May 07 2024 19:05:32 GMT+0900

Copy link
Collaborator

@easyhyun00 easyhyun00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•— ์ง€๊ธˆ ํ™•์ธํ–ˆ๋„ค์š” ใ… ใ… ! ์ด๋Ÿฐ ์‹์œผ๋กœ ์„ฑ๋Šฅ ํ–ฅ์ƒ ์ž‘์—…์„ ํ•  ์ˆ˜ ์žˆ๊ตฐ์š”! ์ €๋„ ๋งŽ์ด ๋ฐฐ์›Œ๊ฐ‘๋‹ˆ๋‹ค
์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@bbearcookie bbearcookie merged commit 19e28a7 into main May 10, 2024
9 checks passed
@bbearcookie bbearcookie deleted the refactor/#299/web-vitals branch May 10, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ”จ Refactor ๋ฆฌํŒฉํ† ๋ง ์ž‘์—…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๋ชจ๋ฐ”์ผ ํผํฌ๋จผ์Šค ๊ฐœ์„ 
2 participants